Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Inline Begin transction for RW transactions #840

Merged
merged 26 commits into from
Dec 14, 2022

Conversation

surbhigarg92
Copy link
Contributor

No description provided.

@surbhigarg92 surbhigarg92 requested review from a team as code owners October 10, 2022 04:54
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/python-spanner API. labels Oct 10, 2022
@surbhigarg92 surbhigarg92 marked this pull request as draft October 10, 2022 04:54
@surbhigarg92 surbhigarg92 changed the title Inline Begin transction for RW transactions feat: Inline Begin transction for RW transactions Oct 10, 2022
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Nov 9, 2022
@surbhigarg92 surbhigarg92 marked this pull request as ready for review November 30, 2022 05:43
google/cloud/spanner_v1/snapshot.py Outdated Show resolved Hide resolved
google/cloud/spanner_v1/snapshot.py Show resolved Hide resolved
google/cloud/spanner_v1/snapshot.py Outdated Show resolved Hide resolved
google/cloud/spanner_v1/snapshot.py Outdated Show resolved Hide resolved
google/cloud/spanner_v1/pool.py Show resolved Hide resolved
tests/unit/test_snapshot.py Show resolved Hide resolved
tests/unit/test_spanner.py Outdated Show resolved Hide resolved
tests/unit/test_transaction.py Show resolved Hide resolved
tests/unit/test_transaction.py Outdated Show resolved Hide resolved
tests/unit/test_transaction.py Show resolved Hide resolved
@surbhigarg92 surbhigarg92 force-pushed the inline_begintransaction branch 2 times, most recently from 4bfa075 to 3a002c4 Compare December 8, 2022 09:28
google/cloud/spanner_v1/snapshot.py Show resolved Hide resolved
google/cloud/spanner_v1/pool.py Outdated Show resolved Hide resolved
google/cloud/spanner_v1/pool.py Show resolved Hide resolved
google/cloud/spanner_v1/transaction.py Show resolved Hide resolved
tests/unit/test_session.py Show resolved Hide resolved
tests/unit/test_session.py Outdated Show resolved Hide resolved
tests/unit/test_snapshot.py Outdated Show resolved Hide resolved
google/cloud/spanner_v1/pool.py Show resolved Hide resolved
surbhigarg92 and others added 4 commits December 12, 2022 14:40
Co-authored-by: larkee <31196561+larkee@users.noreply.github.com>
Co-authored-by: larkee <31196561+larkee@users.noreply.github.com>
Copy link
Contributor

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few style nits 👍

tests/unit/test_session.py Outdated Show resolved Hide resolved
tests/unit/test_snapshot.py Show resolved Hide resolved
@asthamohta asthamohta merged commit c2456be into googleapis:main Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner API. size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants