Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samples: add code samples for PostgreSql dialect #836

Merged
merged 31 commits into from
Oct 26, 2022
Merged

samples: add code samples for PostgreSql dialect #836

merged 31 commits into from
Oct 26, 2022

Conversation

rajatbhatta
Copy link
Contributor

No description provided.

@snippet-bot
Copy link

snippet-bot bot commented Oct 4, 2022 •
edited
Loading

Here is the summary of changes.

You are about to add 44 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: spanner Issues related to the googleapis/python-spanner API. samples Issues that are directly related to samples. labels Oct 4, 2022
@rajatbhatta rajatbhatta added the snippet-bot:force-run Force snippet-bot runs its logic label Oct 6, 2022
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Oct 6, 2022
@rajatbhatta rajatbhatta marked this pull request as ready for review October 11, 2022 05:12
@rajatbhatta rajatbhatta requested review from a team as code owners October 11, 2022 05:12
@rajatbhatta rajatbhatta marked this pull request as draft October 11, 2022 12:38
@rajatbhatta rajatbhatta marked this pull request as ready for review October 11, 2022 14:03
@rajatbhatta rajatbhatta enabled auto-merge (squash) October 12, 2022 07:22
asthamohta
asthamohta reviewed Oct 12, 2022
View reviewed changes
samples/samples/noxfile.py
@@ -180,6 +180,7 @@ def blacken(session: nox.sessions.Session) -> None:
# format = isort + black
#


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:remove extra line

asthamohta
asthamohta reviewed Oct 12, 2022
View reviewed changes
samples/samples/pg_snippets.py
OPERATION_TIMEOUT_SECONDS = 240


# [START spanner_postgresql_create_instance]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A pg instance is not required separately. You can reuse the same instance as google sql instance, and delete this test

asthamohta
asthamohta reviewed Oct 12, 2022
View reviewed changes
samples/samples/pg_snippets.py
database=database_name,
statements=[
"""CREATE TABLE Singers (
SingerId bigint NOT NULL,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can you format this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also can you adda comment that pg is case insensitive or rename it to lower case

@asthamohta asthamohta self-requested a review October 26, 2022 13:35
@asthamohta asthamohta added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 26, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 26, 2022
@asthamohta asthamohta enabled auto-merge (squash) October 26, 2022 16:47
@asthamohta asthamohta added the cla: yes This human has signed the Contributor License Agreement. label Oct 26, 2022
@asthamohta asthamohta merged commit fbb1440 into googleapis:main Oct 26, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asthamohta asthamohta asthamohta approved these changes

@loferris loferris Awaiting requested review from loferris loferris is a code owner automatically assigned from googleapis/python-samples-reviewers

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rajatbhatta @asthamohta @yoshi-kokoro