Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add snippets for Spanner DML with returning clause #811

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

c2nes
Copy link
Contributor

@c2nes c2nes commented Sep 15, 2022

Samples are provided for INSERT, DELETE, and UPDATE in both GoogleSQL and PostgreSQL dialects. To provide a more compelling example for the INSERT case, a generated column has been added in the "create_database" example so that the generated value can be returned in the INSERT examples.

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Sep 15, 2022
@snippet-bot
Copy link

snippet-bot bot commented Sep 15, 2022

Here is the summary of changes.

You are about to add 6 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Sep 15, 2022
@rajatbhatta rajatbhatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 6, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 6, 2022
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Nov 18, 2022
@c2nes c2nes changed the title WIP: Sample snippets for DML returning feat: Add snippets for Spanner DML with returning clause Nov 18, 2022
@c2nes c2nes marked this pull request as ready for review November 18, 2022 20:48
@c2nes c2nes requested review from a team as code owners November 18, 2022 20:48
@c2nes c2nes requested a review from nicain November 18, 2022 20:48
@rajatbhatta rajatbhatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 21, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 21, 2022
Copy link

@xinjiacs xinjiacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Chris, the samples look good to me!

There may be some testing configuration errors about the examples that need to be fixed.

@rajatbhatta rajatbhatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 21, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 21, 2022
Copy link
Contributor

@rajatbhatta rajatbhatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@c2nes
Copy link
Contributor Author

c2nes commented Nov 29, 2022

@rajatbhatta could you merge this for me when you have a chance? I don't think I have access to do so myself

@ansh0l
Copy link
Contributor

ansh0l commented Nov 29, 2022

Looks like some presubmits are still running after last push, we will take a look later again

@rajatbhatta rajatbhatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 29, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 29, 2022
@rajatbhatta
Copy link
Contributor

@c2nes: I’ve enabled auto-merge on the PR. PR should automatically get merged once the kokoro tests pass.

@rajatbhatta rajatbhatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 30, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 30, 2022
@rajatbhatta rajatbhatta added the automerge Merge the pull request once unit tests and other checks pass. label Nov 30, 2022
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 30, 2022
Samples are provided for INSERT, DELETE, and UPDATE in both GoogleSQL
and PostgreSQL dialects. To provide a more compelling example for the
INSERT case, a generated column has been added in the "create_database"
example so that the generated value can be returned in the INSERT
examples.
@rajatbhatta rajatbhatta added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Nov 30, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 30, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 62e55b5 into googleapis:main Nov 30, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants