observability: annotate Session+SessionPool events #1207
+195
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: spanner
odeke-em
force-pushed
the
trace-annotation-SessionPools
branch
3 times, most recently
from
8d6f2b7
to
4bc937e
Compare
ExhibitOn running examples/grpc_instrumentation_enabled.py we get back these traces |
odeke-em
force-pushed
the
trace-annotation-SessionPools
branch
from
4bc937e
to
0d5bf26
Compare
harshachinta
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
odeke-em
force-pushed
the
trace-annotation-SessionPools
branch
from
0d5bf26
to
3617921
Compare
harshachinta
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
odeke-em
force-pushed
the
trace-annotation-SessionPools
branch
2 times, most recently
from
f71d05c
to
eb9dd5a
Compare
harshachinta
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
This change adds annotations for session and session pool events to aid customers in debugging latency issues with session pool malevolence and also for maintainers to figure out which session pool type is the most appropriate. Updates googleapis#1170
This allows us to avoid the flakes with OpenTelemetry's inMemorySpanExporter that might not have received the exported spans yet.
odeke-em
force-pushed
the
trace-annotation-SessionPools
branch
from
b1ea772
to
ab23f09
Compare
|
Kindly cc-ing you @harshachinta. |
harshachinta
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds annotations for session and session pool events to aid customers in debugging latency issues with session pool malevolence and also for maintainers to figure out which session pool type is the most appropriate.
Updates #1170