Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner): add support for Proto Columns #1084

Merged
merged 23 commits into from
May 16, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
7fd2f90
feat: Proto Columns Feature (#909)
harshachinta Mar 27, 2023
ee0bf5b
feat: Proto column feature tests and samples (#921)
harshachinta Apr 3, 2023
0eddbcf
feat: rever autogenerated code
harshachinta Jan 29, 2024
f44d51d
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jan 29, 2024
89d0e7d
Merge branch 'main' into proto-column-enhancement-alpha
harshachinta Jan 29, 2024
2f6f9d7
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jan 29, 2024
84d8ef6
fix: fix code
harshachinta Jan 29, 2024
b1bcf34
fix: fix code
harshachinta Jan 29, 2024
7bdfa28
Merge branch 'main' into proto-column-enhancement-alpha
harshachinta May 3, 2024
bfcb58d
fix(spanner): fix code
harshachinta May 3, 2024
5ff317c
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] May 3, 2024
02b3d5b
fix(spanner): skip emulator due to b/338557401
harshachinta May 3, 2024
01c3b2a
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] May 3, 2024
a7d60a1
fix(spanner): remove samples
harshachinta May 3, 2024
1fa1605
fix(spanner): update coverage
harshachinta May 3, 2024
f658ba0
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] May 3, 2024
f8e2fcc
Merge branch 'main' into proto-column-enhancement-alpha
harshachinta May 6, 2024
eea661f
chore(spanner): update coverage
harshachinta May 6, 2024
9a838e0
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] May 6, 2024
a76980c
fix(spanner): add samples and update proto schema
harshachinta May 11, 2024
19e97d1
fix(spanner): update samples database and emulator DDL
harshachinta May 13, 2024
60afda1
fix(spanner): update admin test to use autogenerated interfaces
harshachinta May 14, 2024
d050479
fix(spanner): comment refactoring
harshachinta May 15, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(spanner): update samples database and emulator DDL
  • Loading branch information
harshachinta committed May 13, 2024
commit 19e97d113a4ab36a31a0ec1acbf5ba066a647bc0
4 changes: 2 additions & 2 deletions samples/samples/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -203,13 +203,13 @@ def database_id():
def proto_columns_database(
spanner_client,
sample_instance,
database_id,
proto_columns_database_id,
proto_columns_database_ddl,
database_dialect,
):
if database_dialect == DatabaseDialect.GOOGLE_STANDARD_SQL:
sample_database = sample_instance.database(
database_id,
proto_columns_database_id,
ddl_statements=proto_columns_database_ddl,
)

Expand Down
5 changes: 5 additions & 0 deletions samples/samples/snippets_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,11 @@ def default_leader_database_id():
return f"leader_db_{uuid.uuid4().hex[:10]}"


@pytest.fixture(scope="module")
def proto_columns_database_id():
return f"test-db-proto-{uuid.uuid4().hex[:10]}"


@pytest.fixture(scope="module")
def database_ddl():
"""Sequence of DDL statements used to set up the database.
Expand Down
4 changes: 4 additions & 0 deletions tests/_fixtures.py
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,10 @@
phone_number STRING(1024) )
PRIMARY KEY (contact_id, phone_type),
INTERLEAVE IN PARENT contacts ON DELETE CASCADE;
CREATE PROTO BUNDLE (
examples.spanner.music.SingerInfo,
examples.spanner.music.Genre,
);
CREATE TABLE all_types (
pkey INT64 NOT NULL,
int_value INT64,
Expand Down
1 change: 0 additions & 1 deletion tests/system/test_session_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -1543,7 +1543,6 @@ def test_multiuse_snapshot_read_isolation_exact_staleness(sessions_database):
sd._check_row_data(after, all_data_rows)


@pytest.mark.skipif(_helpers.USE_EMULATOR, reason="b/338557401")
def test_read_w_index(
shared_instance,
database_operation_timeout,
Expand Down