-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
observability: please update to a newer version of opentelemetry because the current dependency opentelemetry-api:1.1.0 is from April 2021 (3+ years ago) #1173
Closed
Labels
api: spanner
Issues related to the googleapis/python-spanner API.
Comments
product-auto-label
bot
added
the
api: spanner
Issues related to the googleapis/python-spanner API.
label
Jul 25, 2024
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this issue
Jul 25, 2024
This change modernizes trace span attributes by using OpenTelemetry's semantic conventions that are standardized and allow for much better common ground adoption by broader systems, even more as Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more. With this change we've made the replacement of these fields, directly with imports from `opentelemetry.semconv.trace.SpanAttributes`, as: * "db.type" => DB_SYSTEM aka "db.system" * "db.url" => DB_CONNECTION_STRING aka "db.connection_string" * "db.instance" => DB_NAME aka "db.name" * "net.host.name" => NET_HOST_NAME aka "net.host.name" While here, also updated opentelemetry-(api, sdk) dependencies to use versions "1.25.0", then opentelemetry-(instrumentation) to "0.46b0" Fixes googleapis#1170 Fixes googleapis#1173
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this issue
Jul 25, 2024
This change modernizes trace span attributes by using OpenTelemetry's semantic conventions that are standardized and allow for much better common ground adoption by broader systems, even more as Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more. With this change we've made the replacement of these fields, directly with imports from `opentelemetry.semconv.trace.SpanAttributes`, as: * "db.type" => DB_SYSTEM aka "db.system" * "db.url" => DB_CONNECTION_STRING aka "db.connection_string" * "db.instance" => DB_NAME aka "db.name" * "net.host.name" => NET_HOST_NAME aka "net.host.name" While here, also updated opentelemetry-(api, sdk) dependencies to use versions "1.25.0", then opentelemetry-(instrumentation) to "0.46b0" Fixes googleapis#1170 Fixes googleapis#1173
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this issue
Jul 25, 2024
This change modernizes trace span attributes by using OpenTelemetry's semantic conventions that are standardized and allow for much better common ground adoption by broader systems, even more as Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more. With this change we've made the replacement of these fields, directly with imports from `opentelemetry.semconv.trace.SpanAttributes`, as: * "db.type" => DB_SYSTEM aka "db.system" * "db.url" => DB_CONNECTION_STRING aka "db.connection_string" * "db.instance" => DB_NAME aka "db.name" * "net.host.name" => NET_HOST_NAME aka "net.host.name" While here, also updated opentelemetry-(api, sdk) dependencies to use versions "1.25.0", then opentelemetry-(instrumentation) to "0.46b0" Fixes googleapis#1170 Fixes googleapis#1173
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this issue
Jul 25, 2024
This change modernizes trace span attributes by using OpenTelemetry's semantic conventions that are standardized and allow for much better common ground adoption by broader systems, even more as Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more. With this change we've made the replacement of these fields, directly with imports from `opentelemetry.semconv.trace.SpanAttributes`, as: * "db.type" => DB_SYSTEM aka "db.system" * "db.url" => DB_CONNECTION_STRING aka "db.connection_string" * "db.instance" => DB_NAME aka "db.name" * "net.host.name" => NET_HOST_NAME aka "net.host.name" While here, also updated opentelemetry-(api, sdk) dependencies to use versions "1.25.0", then opentelemetry-(instrumentation) to "0.46b0" Fixes googleapis#1170 Fixes googleapis#1173
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this issue
Jul 26, 2024
This change modernizes trace span attributes by using OpenTelemetry's semantic conventions that are standardized and allow for much better common ground adoption by broader systems, even more as Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more. With this change we've made the replacement of these fields, directly with imports from `opentelemetry.semconv.trace.SpanAttributes`, as: * "db.type" => DB_SYSTEM aka "db.system" * "db.url" => DB_CONNECTION_STRING aka "db.connection_string" * "db.instance" => DB_NAME aka "db.name" * "net.host.name" => NET_HOST_NAME aka "net.host.name" While here, also updated opentelemetry-(api, sdk) dependencies to use versions "1.25.0", then opentelemetry-(instrumentation) to "0.46b0" Fixes googleapis#1170 Fixes googleapis#1173
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this issue
Jul 26, 2024
This change modernizes trace span attributes by using OpenTelemetry's semantic conventions that are standardized and allow for much better common ground adoption by broader systems, even more as Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more. With this change we've made the replacement of these fields, directly with imports from `opentelemetry.semconv.trace.SpanAttributes`, as: * "db.type" => DB_SYSTEM aka "db.system" * "db.url" => DB_CONNECTION_STRING aka "db.connection_string" * "db.instance" => DB_NAME aka "db.name" * "net.host.name" => NET_HOST_NAME aka "net.host.name" While here, also updated opentelemetry-(api, sdk) dependencies to use versions "1.25.0", then opentelemetry-(instrumentation) to "0.46b0" Fixes googleapis#1170 Fixes googleapis#1173
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this issue
Jul 26, 2024
This change modernizes trace span attributes by using OpenTelemetry's semantic conventions that are standardized and allow for much better common ground adoption by broader systems, even more as Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more. With this change we've made the replacement of these fields, directly with imports from `opentelemetry.semconv.trace.SpanAttributes`, as: * "db.type" => DB_SYSTEM aka "db.system" * "db.url" => DB_CONNECTION_STRING aka "db.connection_string" * "db.instance" => DB_NAME aka "db.name" * "net.host.name" => NET_HOST_NAME aka "net.host.name" While here, also updated opentelemetry-(api, sdk) dependencies to use versions "1.25.0", then opentelemetry-(instrumentation) to "0.46b0" Fixes googleapis#1170 Fixes googleapis#1173
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this issue
Jul 26, 2024
This change modernizes trace span attributes by using OpenTelemetry's semantic conventions that are standardized and allow for much better common ground adoption by broader systems, even more as Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more. With this change we've made the replacement of these fields, directly with imports from `opentelemetry.semconv.trace.SpanAttributes`, as: * "db.type" => DB_SYSTEM aka "db.system" * "db.url" => DB_CONNECTION_STRING aka "db.connection_string" * "db.instance" => DB_NAME aka "db.name" * "net.host.name" => NET_HOST_NAME aka "net.host.name" While here, also updated opentelemetry-(api, sdk) dependencies to use versions "1.25.0", then opentelemetry-(instrumentation) to "0.46b0" Fixes googleapis#1170 Fixes googleapis#1173
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this issue
Jul 26, 2024
This change modernizes trace span attributes by using OpenTelemetry's semantic conventions that are standardized and allow for much better common ground adoption by broader systems, even more as Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more. With this change we've made the replacement of these fields, directly with imports from `opentelemetry.semconv.trace.SpanAttributes`, as: * "db.type" => DB_SYSTEM aka "db.system" * "db.url" => DB_CONNECTION_STRING aka "db.connection_string" * "db.instance" => DB_NAME aka "db.name" * "net.host.name" => NET_HOST_NAME aka "net.host.name" While here, also updated opentelemetry-(api, sdk) dependencies to use versions "1.25.0", then opentelemetry-(instrumentation) to "0.46b0" Also added in an option toggled by environment variable ENABLE_EXTENDED_TRACING=true which allows spans to be annotated with the SQL statement keyed by "db.statement" Fixes googleapis#1170 Fixes googleapis#1171 Fixes googleapis#1173
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this issue
Jul 26, 2024
This change modernizes trace span attributes by using OpenTelemetry's semantic conventions that are standardized and allow for much better common ground adoption by broader systems, even more as Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more. With this change we've made the replacement of these fields, directly with imports from `opentelemetry.semconv.trace.SpanAttributes`, as: * "db.type" => DB_SYSTEM aka "db.system" * "db.url" => DB_CONNECTION_STRING aka "db.connection_string" * "db.instance" => DB_NAME aka "db.name" * "net.host.name" => NET_HOST_NAME aka "net.host.name" While here, also updated opentelemetry-(api, sdk) dependencies to use versions "1.25.0", then opentelemetry-(instrumentation) to "0.46b0" Also added in an option toggled by environment variable ENABLE_EXTENDED_TRACING=true which allows spans to be annotated with the SQL statement keyed by "db.statement" Fixes googleapis#1170 Fixes googleapis#1171 Fixes googleapis#1173
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this issue
Jul 29, 2024
This change modernizes trace span attributes by using OpenTelemetry's semantic conventions that are standardized and allow for much better common ground adoption by broader systems, even more as Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more. With this change we've made the replacement of these fields, directly with imports from `opentelemetry.semconv.trace.SpanAttributes`, as: * "db.type" => DB_SYSTEM aka "db.system" * "db.url" => DB_CONNECTION_STRING aka "db.connection_string" * "db.instance" => DB_NAME aka "db.name" * "net.host.name" => NET_HOST_NAME aka "net.host.name" While here, also updated opentelemetry-(api, sdk) dependencies to use versions "1.25.0", then opentelemetry-(instrumentation) to "0.46b0" Also added in an option toggled by environment variable ENABLE_EXTENDED_TRACING=true which allows spans to be annotated with the SQL statement keyed by "db.statement" Fixes googleapis#1170 Fixes googleapis#1171 Fixes googleapis#1173
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this issue
Jul 30, 2024
This change modernizes trace span attributes by using OpenTelemetry's semantic conventions that are standardized and allow for much better common ground adoption by broader systems, even more as Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more. With this change we've made the replacement of these fields, directly with imports from `opentelemetry.semconv.trace.SpanAttributes`, as: * "db.type" => DB_SYSTEM aka "db.system" * "db.url" => DB_CONNECTION_STRING aka "db.connection_string" * "db.instance" => DB_NAME aka "db.name" * "net.host.name" => NET_HOST_NAME aka "net.host.name" While here, also updated opentelemetry-(api, sdk) dependencies to use versions "1.25.0", then opentelemetry-(instrumentation) to "0.46b0" Also added in an option toggled by environment variable ENABLE_EXTENDED_TRACING=true which allows spans to be annotated with the SQL statement keyed by "db.statement" Fixes googleapis#1170 Fixes googleapis#1171 Fixes googleapis#1173
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this issue
Jul 31, 2024
This change modernizes trace span attributes by using OpenTelemetry's semantic conventions that are standardized and allow for much better common ground adoption by broader systems, even more as Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more. With this change we've made the replacement of these fields, directly with imports from `opentelemetry.semconv.trace.SpanAttributes`, as: * "db.type" => DB_SYSTEM aka "db.system" * "db.url" => DB_CONNECTION_STRING aka "db.connection_string" * "db.instance" => DB_NAME aka "db.name" * "net.host.name" => NET_HOST_NAME aka "net.host.name" While here, also updated opentelemetry-(api, sdk) dependencies to use versions "1.25.0", then opentelemetry-(instrumentation) to "0.46b0" Also added in an option toggled by environment variable ENABLE_EXTENDED_TRACING=true which allows spans to be annotated with the SQL statement keyed by "db.statement" Fixes googleapis#1170 Fixes googleapis#1171 Fixes googleapis#1173
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this issue
Aug 9, 2024
This change modernizes trace span attributes by using OpenTelemetry's semantic conventions that are standardized and allow for much better common ground adoption by broader systems, even more as Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more. With this change we've made the replacement of these fields, directly with imports from `opentelemetry.semconv.trace.SpanAttributes`, as: * "db.type" => DB_SYSTEM aka "db.system" * "db.url" => DB_CONNECTION_STRING aka "db.connection_string" * "db.instance" => DB_NAME aka "db.name" * "net.host.name" => NET_HOST_NAME aka "net.host.name" While here, also updated opentelemetry-(api, sdk) dependencies to use versions "1.25.0", then opentelemetry-(instrumentation) to "0.46b0" Also added in an option toggled by environment variable ENABLE_EXTENDED_TRACING=true which allows spans to be annotated with the SQL statement keyed by "db.statement" Fixes googleapis#1170 Fixes googleapis#1171 Fixes googleapis#1173
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this issue
Aug 19, 2024
This change modernizes trace span attributes by using OpenTelemetry's semantic conventions that are standardized and allow for much better common ground adoption by broader systems, even more as Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more. With this change we've made the replacement of these fields, directly with imports from `opentelemetry.semconv.trace.SpanAttributes`, as: * "db.type" => DB_SYSTEM aka "db.system" * "db.url" => DB_CONNECTION_STRING aka "db.connection_string" * "db.instance" => DB_NAME aka "db.name" * "net.host.name" => NET_HOST_NAME aka "net.host.name" While here, also updated opentelemetry-(api, sdk) dependencies to use versions "1.25.0", then opentelemetry-(instrumentation) to "0.46b0" Also added in an option toggled by environment variable ENABLE_EXTENDED_TRACING=true which allows spans to be annotated with the SQL statement keyed by "db.statement" Fixes googleapis#1170 Fixes googleapis#1171 Fixes googleapis#1173
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this issue
Sep 10, 2024
This change modernizes trace span attributes by using OpenTelemetry's semantic conventions that are standardized and allow for much better common ground adoption by broader systems, even more as Google Cloud Tracing & Monitoring pushes towards OpenTelemetry more. With this change we've made the replacement of these fields, directly with imports from `opentelemetry.semconv.trace.SpanAttributes`, as: * "db.type" => DB_SYSTEM aka "db.system" * "db.url" => DB_CONNECTION_STRING aka "db.connection_string" * "db.instance" => DB_NAME aka "db.name" * "net.host.name" => NET_HOST_NAME aka "net.host.name" While here, also updated opentelemetry-(api, sdk) dependencies to use versions "1.25.0", then opentelemetry-(instrumentation) to "0.46b0" Also added in an option toggled by environment variable ENABLE_EXTENDED_TRACING=true which allows spans to be annotated with the SQL statement keyed by "db.statement" Fixes googleapis#1170 Fixes googleapis#1171 Fixes googleapis#1173
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this issue
Sep 11, 2024
This change non-invasively introduces dependencies of opentelemetry bringing in the latest dependencies and modernizing them. While here also brought in modern span attributes: * otel.scope.name * otel.scope.version Updates googleapis#1170 Fixes googleapis#1173 Built from PR#1172
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this issue
Sep 11, 2024
This change non-invasively introduces dependencies of opentelemetry bringing in the latest dependencies and modernizing them. While here also brought in modern span attributes: * otel.scope.name * otel.scope.version Updates googleapis#1170 Fixes googleapis#1173 Built from PR googleapis#1172
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this issue
Sep 11, 2024
This change non-invasively introduces dependencies of opentelemetry bringing in the latest dependencies and modernizing them. While here also brought in modern span attributes: * otel.scope.name * otel.scope.version Also added a modernized example and updated the docs. Updates googleapis#1170 Fixes googleapis#1173 Built from PR googleapis#1172
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this issue
Sep 11, 2024
This change non-invasively introduces dependencies of opentelemetry bringing in the latest dependencies and modernizing them. While here also brought in modern span attributes: * otel.scope.name * otel.scope.version Also added a modernized example and updated the docs. Updates googleapis#1170 Fixes googleapis#1173 Built from PR googleapis#1172
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this issue
Sep 11, 2024
This change non-invasively introduces dependencies of opentelemetry bringing in the latest dependencies and modernizing them. While here also brought in modern span attributes: * otel.scope.name * otel.scope.version Also added a modernized example and updated the docs. Updates googleapis#1170 Fixes googleapis#1173 Built from PR googleapis#1172
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this issue
Sep 11, 2024
This change non-invasively introduces dependencies of opentelemetry bringing in the latest dependencies and modernizing them. While here also brought in modern span attributes: * otel.scope.name * otel.scope.version Also added a modernized example and updated the docs. Updates googleapis#1170 Fixes googleapis#1173 Built from PR googleapis#1172
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this issue
Sep 11, 2024
This change non-invasively introduces dependencies of opentelemetry bringing in the latest dependencies and modernizing them. While here also brought in modern span attributes: * otel.scope.name * otel.scope.version Also added a modernized example to produce traces as well with gRPC-instrumentation enabled, and updated the docs. Updates googleapis#1170 Fixes googleapis#1173 Built from PR googleapis#1172
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this issue
Sep 12, 2024
This change non-invasively introduces dependencies of opentelemetry bringing in the latest dependencies and modernizing them. While here also brought in modern span attributes: * otel.scope.name * otel.scope.version Also added a modernized example to produce traces as well with gRPC-instrumentation enabled, and updated the docs. Updates googleapis#1170 Fixes googleapis#1173 Built from PR googleapis#1172
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this issue
Sep 16, 2024
This change non-invasively introduces dependencies of opentelemetry bringing in the latest dependencies and modernizing them. While here also brought in modern span attributes: * otel.scope.name * otel.scope.version Also added a modernized example to produce traces as well with gRPC-instrumentation enabled, and updated the docs. Updates googleapis#1170 Fixes googleapis#1173 Built from PR googleapis#1172
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this issue
Sep 17, 2024
This change non-invasively introduces dependencies of opentelemetry bringing in the latest dependencies and modernizing them. While here also brought in modern span attributes: * otel.scope.name * otel.scope.version Also added a modernized example to produce traces as well with gRPC-instrumentation enabled, and updated the docs. Updates googleapis#1170 Fixes googleapis#1173 Built from PR googleapis#1172
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this issue
Sep 17, 2024
This change non-invasively introduces dependencies of opentelemetry bringing in the latest dependencies and modernizing them. While here also brought in modern span attributes: * otel.scope.name * otel.scope.version Also added a modernized example to produce traces as well with gRPC-instrumentation enabled, and updated the docs. Updates googleapis#1170 Fixes googleapis#1173 Built from PR googleapis#1172
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this issue
Sep 17, 2024
This change non-invasively introduces dependencies of opentelemetry bringing in the latest dependencies and modernizing them. While here also brought in modern span attributes: * otel.scope.name * otel.scope.version Also added a modernized example to produce traces as well with gRPC-instrumentation enabled, and updated the docs. Updates googleapis#1170 Fixes googleapis#1173 Built from PR googleapis#1172
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this issue
Sep 17, 2024
This change non-invasively introduces dependencies of opentelemetry bringing in the latest dependencies and modernizing them. While here also brought in modern span attributes: * otel.scope.name * otel.scope.version Also added a modernized example to produce traces as well with gRPC-instrumentation enabled, and updated the docs. Updates googleapis#1170 Fixes googleapis#1173 Built from PR googleapis#1172
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this issue
Sep 17, 2024
This change non-invasively introduces dependencies of opentelemetry bringing in the latest dependencies and modernizing them. While here also brought in modern span attributes: * otel.scope.name * otel.scope.version Also added a modernized example to produce traces as well with gRPC-instrumentation enabled, and updated the docs. Updates googleapis#1170 Fixes googleapis#1173 Built from PR googleapis#1172
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this issue
Sep 17, 2024
This change non-invasively introduces dependencies of opentelemetry bringing in the latest dependencies and modernizing them. While here also brought in modern span attributes: * otel.scope.name * otel.scope.version Also added a modernized example to produce traces as well with gRPC-instrumentation enabled, and updated the docs. Updates googleapis#1170 Fixes googleapis#1173 Built from PR googleapis#1172
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this issue
Sep 17, 2024
This change non-invasively introduces dependencies of opentelemetry bringing in the latest dependencies and modernizing them. While here also brought in modern span attributes: * otel.scope.name * otel.scope.version Also added a modernized example to produce traces as well with gRPC-instrumentation enabled, and updated the docs. Updates googleapis#1170 Fixes googleapis#1173 Built from PR googleapis#1172
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this issue
Sep 17, 2024
This change non-invasively introduces dependencies of opentelemetry bringing in the latest dependencies and modernizing them. While here also brought in modern span attributes: * otel.scope.name * otel.scope.version Also added a modernized example to produce traces as well with gRPC-instrumentation enabled, and updated the docs. Updates googleapis#1170 Fixes googleapis#1173 Built from PR googleapis#1172
odeke-em
added a commit
to odeke-em/python-spanner
that referenced
this issue
Sep 17, 2024
This change non-invasively introduces dependencies of opentelemetry bringing in the latest dependencies and modernizing them. While here also brought in modern span attributes: * otel.scope.name * otel.scope.version Also added a modernized example to produce traces as well with gRPC-instrumentation enabled, and updated the docs. Updates googleapis#1170 Fixes googleapis#1173 Built from PR googleapis#1172
harshachinta
pushed a commit
that referenced
this issue
Sep 18, 2024
This change non-invasively introduces dependencies of opentelemetry bringing in the latest dependencies and modernizing them. While here also brought in modern span attributes: * otel.scope.name * otel.scope.version Also added a modernized example to produce traces as well with gRPC-instrumentation enabled, and updated the docs. Updates #1170 Fixes #1173 Built from PR #1172
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While working on modernizing the observability in this library I encountered the fact that the constrained minimum version of opentelemetry-api being used is 1.1.0 and that was released in April 2021 (3 years ago) https://pypi.org/project/opentelemetry-api/1.1.0/
per
python-spanner/setup.py
Lines 49 to 53 in fe20d41
Let's get to the latest release of opentelemetry. I am going to send a change
The text was updated successfully, but these errors were encountered: