Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion google/cloud/sqlalchemy_spanner/sqlalchemy_spanner.py
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ def render_literal_value(self, value, type_):
generate a SQL statement.
"""
raw = ["\\", "'", '"', "\n", "\t", "\r"]
if type(value) == str and any(single in value for single in raw):
if isinstance(value, str) and any(single in value for single in raw):
value = 'r"""{}"""'.format(value)
return value
else:
Expand Down
15 changes: 15 additions & 0 deletions test/test_suite_20.py
Original file line number Diff line number Diff line change
Expand Up @@ -2111,6 +2111,10 @@ def test_empty_insert_multiple(self):
def test_insert_from_select_autoinc(self):
pass

@pytest.mark.skip("Spanner does not support auto increment")
def test_no_results_for_non_returning_insert(self, connection, style, executemany):
pass

def test_autoclose_on_insert(self):
"""
SPANNER OVERRIDE:
Expand Down Expand Up @@ -2495,6 +2499,17 @@ class IsOrIsNotDistinctFromTest(_IsOrIsNotDistinctFromTest):
pass


@pytest.mark.skip("Spanner doesn't bizarre characters in foreign key names")
class BizarroCharacterFKResolutionTest(fixtures.TestBase):
pass


class IsolationLevelTest(fixtures.TestBase):
@pytest.mark.skip("Cloud Spanner does not support different isolation levels")
def test_dialect_user_setting_is_restored(self, testing_engine):
pass


class OrderByLabelTest(_OrderByLabelTest):
@pytest.mark.skip(
"Spanner requires an alias for the GROUP BY list when specifying derived "
Expand Down