Skip to content

feat: support SQLAlchemy 1.4 #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Jan 27, 2022
Merged

feat: support SQLAlchemy 1.4 #191

merged 29 commits into from
Jan 27, 2022

Conversation

IlyaFaer
Copy link
Contributor

@IlyaFaer IlyaFaer commented Jan 13, 2022

The first step in terms of supporting SQLAlchemy 1.4 is to prepare tests suite.

This PR splits the original test suite into two suites: 1.3 and 1.4. Though there were not much of a functionality changes between the versions, the tests suite changed significantly, thus, we need to support separate suites for the 1.3 and 1.4 versions for now.

@IlyaFaer IlyaFaer added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 13, 2022
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. label Jan 13, 2022
@vi3k6i5 vi3k6i5 linked an issue Jan 18, 2022 that may be closed by this pull request
@IlyaFaer IlyaFaer changed the title Sqlalchemy14 feat: support SQLAlchemy 1.4 Jan 19, 2022
@IlyaFaer IlyaFaer marked this pull request as ready for review January 19, 2022 08:52
@IlyaFaer IlyaFaer requested a review from a team January 19, 2022 08:53
@IlyaFaer
Copy link
Contributor Author

@vi3k6i5, this better be processed in high priority, as it includes complex changes, which can affect (or be affected) by other changes.

It also requires some kokoro changes, as now there is no compliance_test session, but compliance_test_13 and compliance_test_14.

@IlyaFaer IlyaFaer removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 24, 2022
@IlyaFaer IlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 25, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 25, 2022
@IlyaFaer IlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 25, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 25, 2022
@IlyaFaer
Copy link
Contributor Author

@vi3k6i5, all the checks passed except the old and unactual one (it should be dropped in the repo setting, I guess).
Can be merged now.

Copy link
Contributor

@vi3k6i5 vi3k6i5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IlyaFaer
Copy link
Contributor Author

@vi3k6i5, please, merge it
I don't have admin access in the repo, so I can only merge it if all the checks passed. But we have this never executed compliance_tests, so I'm a bit helpless.

@vi3k6i5 vi3k6i5 closed this Jan 27, 2022
@vi3k6i5 vi3k6i5 reopened this Jan 27, 2022
@@ -3,5 +3,5 @@
# Only run this nox session.
env_vars: {
key: "NOX_SESSION"
value: "compliance_test"
value: "compliance_test_13"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IlyaFaer : What about compliance_test_14 ? we won't enable it by default ?

@vi3k6i5
Copy link
Contributor

vi3k6i5 commented Jan 27, 2022

Disabled Compliance test to merge the change as we have renamed it to compliance_test_13 and compliance_test_14. will enable it once this PR is merged.

@vi3k6i5 vi3k6i5 merged commit 029b181 into main Jan 27, 2022
@vi3k6i5 vi3k6i5 deleted the sqlalchemy14 branch January 27, 2022 08:10
This was referenced Jan 27, 2022
@vi3k6i5
Copy link
Contributor

vi3k6i5 commented Jan 28, 2022

compliance_test_13 and compliance_test_14 are now enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: compliance_test is failing
3 participants