-
Notifications
You must be signed in to change notification settings - Fork 33
feat: support SQLAlchemy 1.4 #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@vi3k6i5, this better be processed in high priority, as it includes complex changes, which can affect (or be affected) by other changes. It also requires some |
@vi3k6i5, all the checks passed except the old and unactual one (it should be dropped in the repo setting, I guess). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@vi3k6i5, please, merge it |
@@ -3,5 +3,5 @@ | |||
# Only run this nox session. | |||
env_vars: { | |||
key: "NOX_SESSION" | |||
value: "compliance_test" | |||
value: "compliance_test_13" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@IlyaFaer : What about compliance_test_14 ? we won't enable it by default ?
Disabled Compliance test to merge the change as we have renamed it to compliance_test_13 and compliance_test_14. will enable it once this PR is merged. |
compliance_test_13 and compliance_test_14 are now enabled. |
The first step in terms of supporting SQLAlchemy 1.4 is to prepare tests suite.
This PR splits the original test suite into two suites: 1.3 and 1.4. Though there were not much of a functionality changes between the versions, the tests suite changed significantly, thus, we need to support separate suites for the 1.3 and 1.4 versions for now.