Skip to content

chore: update benchmark to better compare performance #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 25, 2021
Merged

chore: update benchmark to better compare performance #157

merged 3 commits into from
Nov 25, 2021

Conversation

larkee
Copy link
Contributor

@larkee larkee commented Nov 25, 2021

Benchmark has been updated to:

  • Use same generated IDs for each run so there are no timing differences related to splits
  • Use placeholders for Spanner's insert_many_rows to ensure the backend request is the same as SQLAlchemy

There are also changes to improve the usability of the script i.e.instance and database setup will now include creation or recreation as needed.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 25, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. label Nov 25, 2021
@larkee larkee marked this pull request as ready for review November 25, 2021 03:25
@larkee larkee merged commit 0299739 into googleapis:main Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skuruppu skuruppu skuruppu approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@larkee @skuruppu