Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performance testing harness #438

Closed
odeke-em opened this issue Apr 22, 2020 · 4 comments
Closed

performance testing harness #438

odeke-em opened this issue Apr 22, 2020 · 4 comments
Labels
api: spanner Issues related to the googleapis/python-spanner-django API. priority: p3 Desirable enhancement or fix. May not be included in next release.

Comments

@odeke-em
Copy link
Contributor

I've been requested that we should set up a performance test harness. Very tricky one because we can't directly measure against the client libraries. An apples to apples comparison would perhaps
be using spanner_dbapi, but django-spanner itself is tricky to set up.

@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner-django API. label Apr 22, 2020
@odeke-em odeke-em added the priority: p0 Highest priority. Critical issue. P0 implies highest priority. label Apr 22, 2020
@odeke-em
Copy link
Contributor Author

A while back, I create a benchmarking repository for spanner_dbapi vs the Python client library, at https://github.com/orijtech/spanner-benchmarking
which uses OpenCensus and Prometheus to visualize results e.g.

Screen Shot 2020-04-22 at 2 50 17 PM

@odeke-em
Copy link
Contributor Author

I've spun up this code https://gist.github.com/odeke-em/929d308f1fb80a1661d2e3ccb6a7b58b which produces ineresting results when comparing benchmarks https://gist.github.com/odeke-em/929d308f1fb80a1661d2e3ccb6a7b58b#file-results-md

name                old time/op  new time/op  delta
ReadOnly            93.7ms ±18%  87.6ms ±11%   -6.50%  (p=0.007 n=20+18)
ReadWrite           87.5ms ±13%  91.9ms ±39%     ~     (p=0.153 n=96+83)
CreateDestroyTable   47.3s ±20%   17.7s ±47%  -62.49%  (p=0.002 n=6+6)

@c24t c24t added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p0 Highest priority. Critical issue. P0 implies highest priority. labels Aug 13, 2020
@paul1319 paul1319 removed their assignment Oct 17, 2020
@FirePing32
Copy link

@odeke-em Can you tell me more about how to return results (display them in terminal or store them somewhere)

@asthamohta
Copy link
Contributor

#675 We have also done benchmark testing here where Spanner vs Django performance are tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner-django API. priority: p3 Desirable enhancement or fix. May not be included in next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants