Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use version.py instead of pkg_resources.get_distribution #184

Merged
merged 5 commits into from
Nov 15, 2023
Merged

fix: use version.py instead of pkg_resources.get_distribution #184

merged 5 commits into from
Nov 15, 2023

Conversation

bricker
Copy link
Contributor

@bricker bricker commented May 10, 2023

@bricker bricker requested a review from a team as a code owner May 10, 2023 21:32
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: runtimeconfig Issues related to the googleapis/python-runtimeconfig API. labels May 10, 2023
@parthea parthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 15, 2023
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 15, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 15, 2023
@parthea parthea merged commit 2a7b9d0 into googleapis:main Nov 15, 2023
14 checks passed
@release-please release-please bot mentioned this pull request Nov 15, 2023
Merged
@parthea parthea mentioned this pull request Nov 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthea parthea parthea approved these changes

Assignees
No one assigned
Labels
api: runtimeconfig Issues related to the googleapis/python-runtimeconfig API. kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't use pkg_resources.get_distribution(..).version
2 participants
@bricker @parthea