Skip to content

Conversation

@acocuzzo
Copy link
Contributor

@acocuzzo acocuzzo commented Apr 14, 2022

Add comments to sample, as well as edit docstrings for ack, ack_with_response, modify ack deadline, and nack_with_response linking to exactly once delivery documentation.

Also swapped exactly once delivery NOT enabled descriptions to come first, so that the default case is shown first.

Fixes #617

@acocuzzo acocuzzo requested review from a team as code owners April 14, 2022 20:19
@acocuzzo acocuzzo requested a review from loferris April 14, 2022 20:19
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: pubsub Issues related to the googleapis/python-pubsub API. labels Apr 14, 2022
Copy link
Contributor

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Anna.

@acocuzzo acocuzzo merged commit 418e1a3 into googleapis:main Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the googleapis/python-pubsub API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mark exactly once delivery as a preview feature

2 participants