Skip to content

chore: release 1.3.0 #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 20, 2020
Merged

chore: release 1.3.0 #27

merged 2 commits into from
Feb 20, 2020

Conversation

release-please[bot]
Copy link
Contributor

@release-please release-please bot commented Feb 5, 2020 •
edited
Loading

🤖 I have created a release *beep* *boop*

1.3.0 (2020-02-20)

Features

  • pubsub: ordering keys (#26) (cc3093a)
  • add context manager capability to subscriber (#32) (b58d0d8)

This PR was generated with Release Please.

@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 5, 2020
@release-please release-please bot added autorelease: pending type: process A process-related concern. May include testing, release, or the like. labels Feb 5, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 5, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 5, 2020
plamut
plamut reviewed Feb 6, 2020
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment on the wording.

Optional: Fix release notes from the previous release? (dead issue links, wording)

CHANGELOG.md

### Features

* **pubsub:** ordering keys ([#26](https://www.github.com/googleapis/python-pubsub/issues/26)) ([cc3093a](https://www.github.com/googleapis/python-pubsub/commit/cc3093a2c0304259bc374bc2eeec9630e4a11a5e))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The **pubsub:** prefix is redundant here, and release notes should contain full sentences (AFAIK).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I talked to Ben (who made the bot) and he says it just comes from the "pubsub" part of "feat(pubsub)". The part between the parens just provides extra context. We can omit it unless we want to standardize on a few contextual tags: tests, system-tests, gapic, publish-path, subscribe-path, etc. Just a thought.

I'm going to merge the PR and then send a follow-up to clean up these unnecessary "pubsub" tags.

@plamut
Copy link
Contributor

plamut commented Feb 6, 2020

General question - is a human supposed to change any stuff that might not be desired in the PR, or is the bot's version final, and the release notes format used here is the new norm?

@plamut
Copy link
Contributor

plamut commented Feb 7, 2020

As per meeting notes - ordering keys should not be released just yet, as there is still some pending work remaining.

@plamut plamut added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 7, 2020
@release-please release-please bot closed this Feb 14, 2020
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 14, 2020
@release-please release-please bot reopened this Feb 14, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 14, 2020
@release-please release-please bot closed this Feb 20, 2020
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 20, 2020
@release-please release-please bot reopened this Feb 20, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 20, 2020
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:run Add this label to force Kokoro to re-run the tests. labels Feb 20, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 20, 2020
@pradn pradn merged commit e73e5e7 into master Feb 20, 2020
@yoshi-automation
Copy link
Contributor

Release is at https://github.com/googleapis/python-pubsub/releases/tag/v1.3.0

@yoshi-automation
Copy link
Contributor

The release build has started, the log can be viewed here. 🌻

@yoshi-automation
Copy link
Contributor

🥚 You hatched a release! The release build finished successfully! 💜

@plamut plamut removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plamut plamut plamut left review comments

@pradn pradn pradn approved these changes

Assignees
No one assigned
Labels
autorelease: published cla: yes This human has signed the Contributor License Agreement. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@plamut @yoshi-automation @pradn @googlebot @yoshi-kokoro