-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove restriction that protobuf should be less than 5 #1193
Conversation
@parthea PTAL when free. |
I would very much like to have this fixed as well, for similar reasons to #1192 |
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Also update Change python-pubsub/testing/constraints-3.7.txt Line 10 in 0b8d7b9
to
|
78ee38b
to
5995757
Compare
The system tests are failing due to an unrelated issue.
|
3df084a
to
86ecee0
Compare
86ecee0
to
cd879a6
Compare
@jeffsawatzky and @cglewis . The fix is submitted and available in the latest release |
I see that an upper bound of 5 was set on the protobuf library in 23ce35e
I do not find any documentation on reasons for keeping an upper bound. Proposing removing the upper bound in this PR, but also checking if there are any reasons we would not want to do this from @parthea who would have historical context on this.
Fixes #1192 🦕
BEGIN_COMMIT_OVERRIDE
fix: allow Protobuf 5.x
END_COMMIT_OVERRIDE