Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persist mypy nox session #545

Closed
plamut opened this issue Dec 2, 2021 · 0 comments · Fixed by #546
Closed

Persist mypy nox session #545

plamut opened this issue Dec 2, 2021 · 0 comments · Fixed by #546
Assignees
@plamut
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. type: process A process-related concern. May include testing, release, or the like.

Comments

@plamut
Copy link
Contributor

plamut commented Dec 2, 2021

The mypy session was manually added to the noxfile, which is auto-generated, thus OwlBot overrides those changes (#544).

Instead, the changes should be injected into noxfile.py through owlbot.py replacements, at least until mypy session is not added by the code generator itself.
@plamut plamut added the type: process A process-related concern. May include testing, release, or the like. label Dec 2, 2021
@plamut plamut self-assigned this Dec 2, 2021
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Dec 2, 2021
@plamut plamut mentioned this issue Dec 2, 2021
Merged
4 tasks
@plamut plamut mentioned this issue Dec 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plamut plamut

Labels
api: pubsub Issues related to the googleapis/python-pubsub API. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

process: persist mypy session in noxfile plamut/python-pubsub
1 participant
@plamut