-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: repeated structured property containing blob property with legacy_data (#817) #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
product-auto-label
bot
added
the
api: datastore
Issues related to the googleapis/python-ndb API.
label
Feb 13, 2024
ventice11o
changed the title
Fix inability to create repeated structured properties containing a blob property (or its heir JSON property) with legacy_data=True
Fix: Fixed #817: Inability to create repeated structured properties containing a blob property with legacy_data=True
Feb 13, 2024
ventice11o
changed the title
Fix: Fixed #817: Inability to create repeated structured properties containing a blob property with legacy_data=True
fix: Inability to create repeated structured properties containing a blob property with legacy_data=True (googleapis#817)
Feb 13, 2024
ventice11o
changed the title
fix: Inability to create repeated structured properties containing a blob property with legacy_data=True (googleapis#817)
fix: repeated structured property containing blob property with legacy_data (googleapis#817)
Feb 13, 2024
ventice11o
changed the title
fix: repeated structured property containing blob property with legacy_data (googleapis#817)
fix: repeated structured property containing blob property with legacy_data (#817)
Feb 13, 2024
parthea
added
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
kokoro:run
Add this label to force Kokoro to re-run the tests.
owlbot:run
Add this label to trigger the Owlbot post processor.
labels
Feb 13, 2024
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Feb 13, 2024
yoshi-kokoro
removed
kokoro:run
Add this label to force Kokoro to re-run the tests.
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
labels
Feb 13, 2024
sorced-jim
added
kokoro:run
Add this label to force Kokoro to re-run the tests.
owlbot:run
Add this label to trigger the Owlbot post processor.
labels
Feb 27, 2024
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Feb 27, 2024
yoshi-kokoro
removed
the
kokoro:run
Add this label to force Kokoro to re-run the tests.
label
Feb 27, 2024
sorced-jim
reviewed
Feb 27, 2024
sorced-jim
added
kokoro:run
Add this label to force Kokoro to re-run the tests.
owlbot:run
Add this label to trigger the Owlbot post processor.
labels
Feb 29, 2024
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Feb 29, 2024
yoshi-kokoro
removed
the
kokoro:run
Add this label to force Kokoro to re-run the tests.
label
Feb 29, 2024
sorced-jim
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue #817
In case of legacy data and repeated structured property, the
value
variable inBlobProperty._to_datastore
is a list and not abytes
or_CompressedValue
object thus the expressionvalue.startswith(_ZLIB_COMPRESSION_MARKERS)
fails. So,_MEANING_COMPRESSED
is set for this list, it will work only if all the values of the list are not None, otherwise the RPC call fails with exception that the meaning 22 is not compatible with the bytes_value (which is None). So, in general case the meaning is not applicable to this combined value. Unless the back end supports such mixed values, or allows for meanings for None, we cannot use meanings. Technically, I can set the meaning if all the values of the list are non None, but in my opinion it is more consistent this way.All the tests have passed, including the new ones. Without the changes in PR, both tests fail with
AttributeError
.