Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document requirement of Redis/Memcached for running all the unit tests #836

Closed
rwhogg opened this issue Nov 16, 2022 · 0 comments · Fixed by #838 or #833
Closed

Document requirement of Redis/Memcached for running all the unit tests #836

rwhogg opened this issue Nov 16, 2022 · 0 comments · Fixed by #838 or #833
Labels
api: datastore Issues related to the googleapis/python-ndb API.

Comments

@rwhogg
Copy link
Contributor

rwhogg commented Nov 16, 2022

You both a) need to have them running and b) set some environment variables.

These details should probably be documented in CONTRIBUTING.rst
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/python-ndb API. label Nov 16, 2022
rwhogg added a commit to rwhogg/python-ndb that referenced this issue Nov 16, 2022
@rwhogg
docs(CONTRIBUTING): Note the need for Redis/Memcached env vars in tests
d833fe5 
Fixes googleapis#836
@rwhogg rwhogg mentioned this issue Nov 16, 2022
Merged
meredithslota pushed a commit that referenced this issue Nov 17, 2022
@rwhogg @parthea
docs(CONTRIBUTING): Note the need for Redis/Memcached env vars in tes…
19f8415 
…ts (#838)

Fixes #836

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@release-please release-please bot mentioned this issue Nov 17, 2022
Merged
This was referenced Sep 14, 2023
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: datastore Issues related to the googleapis/python-ndb API.
Projects
None yet
Milestone
No milestone
1 participant
@rwhogg