-
Notifications
You must be signed in to change notification settings - Fork 7
chore: migrate to main branch #98
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor observations, otherwise LGTM
README.rst
Outdated
@@ -10,7 +10,7 @@ retrieval of critical metadata about all of your software artifacts. | |||
- `Product Documentation`_ | |||
|
|||
.. |ga| image:: https://img.shields.io/badge/support-ga-gold.svg | |||
:target: https://github.com/googleapis/google-cloud-python/blob/master/README.rst#general-availability | |||
:target: https://github.com/googleapis/google-cloud-python/blob/main/README.rst#general-availability |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get 404 with the new link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
samples/AUTHORING_GUIDE.md
Outdated
See https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/AUTHORING_GUIDE.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get 404 with the new link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Please take a look again! |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #97 🦕