feat: add pipeline query parity #1047
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
pipeline_queries_1_stubs
to
pipeline_queries_approved
June 17, 2025 22:54
|
Closing so I can reorder PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends pipeline expressions to allow converting from a Query to a Pipeline expression. All necessary stages and expressions have been added
Most of the changes in the PR is relatively boiler plate. pipeline_stages and pipeline_expressions have some new classes. But the main change to review is
base_query.pipeline(), which implements the conversion from query to pipeline formatNote:
The intention of this PR was to have all system test queries add
verify_query, to compare results between pipelines and standard RunQuery calls. But RunQuery is currently not available in enterprise dbs. Instead, the PR adds the configuration to run those tests locally, with a TODO (and related GitHub issue) to add it to the CI in the future