-
Notifications
You must be signed in to change notification settings - Fork 20
fix: Add trailing slash if not present for gcs_prefix in Document.from_gcs() to cover matching prefixes edge case.
#274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecbc331 to
ec28a76
Compare
Member
Author
|
Error Message appeared in Tests before |
dizcology
reviewed
Mar 8, 2024
7ecb9fe to
a9340f7
Compare
gcs_prefix in from_batch_process_metadata() to cover matching prefixes edge case.gcs_prefix in Document.from_gcs() to cover matching prefixes edge case.
…from_gcs()` to cover matching prefixes edge case.
a9340f7 to
6ff8f4c
Compare
parthea
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #271 🦕