feat: support conversion from pyarrow RecordBatch to pandas DataFrame #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigquery
google-cla
bot
added
the
cla: yes
tswast
commented
Nov 3, 2021
TODO: add tests for constructing pandas Series with pyarrow scalars
|
3.10 failure should be resolved by #40 |
Merged
tseaver
reviewed
Nov 4, 2021
tswast
commented
Nov 4, 2021
tswast
commented
Nov 4, 2021
loferris
reviewed
Nov 5, 2021
loferris
reviewed
Nov 5, 2021
| ), | ||
| ), | ||
| ] | ||
|
|
There was a problem hiding this comment.
Similarly, I'm curious what happens if the PyArrow type is timestamp("ns"), just to cover all possible inputs.
There was a problem hiding this comment.
I assume you meant time64("ns"). I've added a test case, which uncovered a bug in _datetime, which I've fixed.
loferris
approved these changes
Nov 5, 2021
tswast
added
automerge
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Nov 8, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [0.3.0](https://www.github.com/googleapis/python-db-dtypes-pandas/compare/v0.2.0...v0.3.0) (2021-11-08) ### Features * support conversion from pyarrow RecordBatch to pandas DataFrame ([#39](https://www.github.com/googleapis/python-db-dtypes-pandas/issues/39)) ([facc7b0](https://www.github.com/googleapis/python-db-dtypes-pandas/commit/facc7b0897e27c5ba99399b7d453818c5b4aeca7)) * support Python 3.10 ([#40](https://www.github.com/googleapis/python-db-dtypes-pandas/issues/40)) ([a31d55d](https://www.github.com/googleapis/python-db-dtypes-pandas/commit/a31d55db57b2f5655b1fee4230a930d5bee4b1c9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #38 🦕