Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new_transaction support #499

Merged
merged 47 commits into from
Apr 4, 2024
Merged
Changes from 1 commit
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
d7fe72d
added begin_later flag
daniel-sanche Nov 28, 2023
14942e0
refactoring
daniel-sanche Nov 28, 2023
8ce4654
got tests passing
daniel-sanche Nov 28, 2023
18d6a34
improved docstring
daniel-sanche Nov 28, 2023
af92f68
added helper tests
daniel-sanche Nov 28, 2023
11cedac
fixed type in docstring
daniel-sanche Nov 28, 2023
27454d5
added client test
daniel-sanche Nov 28, 2023
b952b8d
handle context manager close
daniel-sanche Nov 28, 2023
81108df
removed extra indents
daniel-sanche Nov 28, 2023
defd080
added transaction tests
daniel-sanche Nov 28, 2023
2063f71
added system tests
daniel-sanche Nov 28, 2023
648204d
fixed lint
daniel-sanche Nov 28, 2023
087eaaf
refactor using wrappers
daniel-sanche Nov 28, 2023
cbb2c0a
added functools.wraps
daniel-sanche Nov 29, 2023
471ead2
fixed mypy
daniel-sanche Nov 29, 2023
439604c
Merge branch 'main' into new_transaction
daniel-sanche Nov 29, 2023
8da9e00
fixed mypy
daniel-sanche Nov 29, 2023
95797e9
added test
daniel-sanche Nov 29, 2023
09d945f
default begin_later to False
daniel-sanche Nov 30, 2023
3409196
Merge branch 'main' into new_transaction
daniel-sanche Dec 1, 2023
210c5d8
Merge branch 'main' into new_transaction
daniel-sanche Dec 1, 2023
d63cb90
Merge branch 'main' into new_transaction
daniel-sanche Dec 4, 2023
982b998
added new_transaction to query and aggregation classes
daniel-sanche Dec 15, 2023
e7b8b9a
chore(deps): update all dependencies (#505)
renovate-bot Dec 7, 2023
026c934
build: update actions/checkout and actions/setup-python (#507)
gcf-owl-bot[bot] Dec 10, 2023
a001d5f
chore(main): release 2.19.0 (#481)
release-please[bot] Dec 12, 2023
aef3bef
chore(deps): update dependency google-cloud-datastore to v2.19.0 (#508)
renovate-bot Dec 12, 2023
3c2e4a7
build: update actions/upload-artifact and actions/download-artifact (…
gcf-owl-bot[bot] Dec 15, 2023
3ac41ea
got tests passing
daniel-sanche Dec 15, 2023
7e8bb6e
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Dec 15, 2023
78bdba6
Merge branch 'main' into new_transaction
daniel-sanche Feb 9, 2024
4ad1071
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Feb 9, 2024
ce9e335
remove begin from put and delete
daniel-sanche Feb 9, 2024
28f6d10
fixed jinja version
daniel-sanche Feb 9, 2024
61237b3
fixed tests
daniel-sanche Feb 9, 2024
77e410a
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Feb 9, 2024
f4512ba
remove unused decorator
daniel-sanche Feb 9, 2024
b2012a8
removed unneeded delete override
daniel-sanche Feb 9, 2024
cfa11db
fixed commit without begin call
daniel-sanche Feb 23, 2024
efc8e8d
improved tests
daniel-sanche Feb 23, 2024
6872fcf
refactored out helper function
daniel-sanche Feb 23, 2024
19ed6e9
fixed lint
daniel-sanche Feb 23, 2024
4682186
added comment
daniel-sanche Feb 23, 2024
abf29e3
added tests for helper
daniel-sanche Feb 23, 2024
8061202
Merge branch 'main' into new_transaction
daniel-sanche Mar 5, 2024
c90da29
Merge branch 'main' into new_transaction
daniel-sanche Mar 7, 2024
4b40a87
Merge branch 'main' into new_transaction
daniel-sanche Apr 4, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed type in docstring
  • Loading branch information
daniel-sanche committed Nov 28, 2023
commit 11cedaca3e3c4a50e85858975253e4061702d1a6
4 changes: 2 additions & 2 deletions google/cloud/datastore/transaction.py
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ def __init__(self, client, read_only=False, read_time=None, begin_later=True):
def id(self):
"""Getter for the transaction ID.

:rtype: str or None
:rtype: bytes or None
:returns: The ID of the current transaction, or None if not started.
"""
return self._id
Expand Down Expand Up @@ -255,7 +255,7 @@ def _begin_with_id(self, transaction_id):
This is used when begin_later is True, when the first lookup request
associated with this transaction creates a new transaction ID.

:type transaction_id: str
:type transaction_id: bytes
:param transaction_id: ID of the transaction to attach to.
"""
if self._status is not self._INITIAL:
Expand Down