Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: release 1.4.2 #30

Merged
merged 1 commit into from
Sep 29, 2020
Merged

chore: release 1.4.2 #30

merged 1 commit into from
Sep 29, 2020

Conversation

release-please[bot]
Copy link
Contributor

@release-please release-please bot commented Sep 21, 2020 •
edited
Loading

🤖 I have created a release *beep* *boop*

1.4.2 (2020-09-29)

Bug Fixes

  • handle query_params tuples in JSONConnection.build_api_url (#34) (6a9adb3)

Performance Improvements

  • use prettyPrint=false by default (#28) (c407b5d)

This PR was generated with Release Please.

@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 21, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 21, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 21, 2020
@release-please release-please bot requested a review from a team as a code owner September 22, 2020 18:30
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 22, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 22, 2020
@tswast
Copy link
Contributor

tswast commented Sep 23, 2020

Need to wait for #34, which fixed the prettyPrint logic when lists of tuples are passed in.

@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 24, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 24, 2020
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 29, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 29, 2020
@tswast tswast requested a review from busunkim96 September 29, 2020 20:07
@tswast
Copy link
Contributor

tswast commented Sep 29, 2020

Updated the PRs referenced in #35 to use the rc2 release.

No failures due to prettyPrint=false so far.

CC @shollyman

@tswast tswast merged commit 7136241 into master Sep 29, 2020
@yoshi-automation
Copy link
Contributor

Release is at https://github.com/googleapis/python-cloud-core/releases/tag/v1.4.2

@tswast tswast deleted the release-v1.4.2 branch September 29, 2020 20:56
@tswast tswast restored the release-v1.4.2 branch September 29, 2020 20:56
@busunkim96 busunkim96 mentioned this pull request Oct 2, 2020
Closed
@busunkim96 busunkim96 deleted the release-v1.4.2 branch October 2, 2020 17:41
@busunkim96 busunkim96 mentioned this pull request Oct 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

@tswast tswast tswast approved these changes

Assignees
No one assigned
Labels
autorelease: tagged cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tswast @yoshi-automation @busunkim96 @yoshi-kokoro