-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update templated files #1016
chore: update templated files #1016
Conversation
Source-Link: googleapis/synthtool@373d00f Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2dc6f67639bee669c33c6277a624ab9857d363e2fd33ac5b02d417b7d25f1ffc
The |
So is the docs-presubmit check not doing anything useful? Will the docs still update as expected even if the test fails? |
Correct. The publish docs job runs
Yes, the docs job can succeed even thought the presubmit fails because they are 2 different scripts as noted above. In addition, the docker file is built on the fly. I've filed a bug to remove this step to improve the success of the jobs pipeline: googleapis/synthtool#2007 |
Wait for cl/667593059 |
Source-Link: googleapis/synthtool@373d00f
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2dc6f67639bee669c33c6277a624ab9857d363e2fd33ac5b02d417b7d25f1ffc