Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update templated files #1016

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Aug 15, 2024

Source-Link: googleapis/synthtool@373d00f
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2dc6f67639bee669c33c6277a624ab9857d363e2fd33ac5b02d417b7d25f1ffc

Source-Link: googleapis/synthtool@373d00f
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2dc6f67639bee669c33c6277a624ab9857d363e2fd33ac5b02d417b7d25f1ffc
@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners August 15, 2024 17:46
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 15, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigtable Issues related to the googleapis/python-bigtable API. labels Aug 15, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 15, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 15, 2024
@parthea parthea changed the title chore: removes docs-presubmit.cfg template chore: update templated files Aug 26, 2024
@parthea
Copy link
Contributor

parthea commented Aug 26, 2024

The Kokoro docs-presubmit job will be removed in cl/667593059

@daniel-sanche
Copy link
Contributor

So is the docs-presubmit check not doing anything useful? Will the docs still update as expected even if the test fails?

@parthea
Copy link
Contributor

parthea commented Aug 27, 2024

So is the docs-presubmit check not doing anything useful?

Correct. The publish docs job runs /.kokoro/publish-docs.sh here where as the current docs presubmit job runs /.kokoro/build.sh here. When we call build.sh in the docs-presubmit job we're just running the docs/docfx nox sessions which is already done using Github Actions(See docfx presubmit). We're not testing the publish-docs.sh script or the Dockerfile here.

Will the docs still update as expected even if the test fails?

Yes, the docs job can succeed even thought the presubmit fails because they are 2 different scripts as noted above. In addition, the docker file is built on the fly. I've filed a bug to remove this step to improve the success of the jobs pipeline: googleapis/synthtool#2007

@parthea
Copy link
Contributor

parthea commented Aug 29, 2024

Wait for cl/667593059

@parthea parthea merged commit 049d45a into main Sep 17, 2024
30 of 32 checks passed
@parthea parthea deleted the owl-bot-update-lock-2dc6f67639bee669c33c6277a624ab9857d363e2fd33ac5b02d417b7d25f1ffc branch September 17, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/python-bigtable API. owl-bot-update-lock size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants