Skip to content

Commit

Permalink
chore(python): Update the python version in docs presubmit to use 3.10 (
Browse files Browse the repository at this point in the history
#1061)

* chore(python): Update the python version in docs presubmit to use 3.10

Source-Link: googleapis/synthtool@de3def6
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:a1c5112b81d645f5bbc4d4bbc99d7dcb5089a52216c0e3fb1203a0eeabadd7d5

* loosen assertion

* update sync

* fixed mypy issue

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Daniel Sanche <sanche@google.com>
  • Loading branch information
3 people authored Jan 8, 2025
1 parent 9c6f79d commit 4f60bd1
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 9 deletions.
6 changes: 3 additions & 3 deletions .github/.OwlBot.lock.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2024 Google LLC
# Copyright 2025 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand All @@ -13,5 +13,5 @@
# limitations under the License.
docker:
image: gcr.io/cloud-devrel-public-resources/owlbot-python:latest
digest: sha256:8e3e7e18255c22d1489258d0374c901c01f9c4fd77a12088670cd73d580aa737
# created: 2024-12-17T00:59:58.625514486Z
digest: sha256:a1c5112b81d645f5bbc4d4bbc99d7dcb5089a52216c0e3fb1203a0eeabadd7d5
# created: 2025-01-02T23:09:36.975468657Z
2 changes: 1 addition & 1 deletion .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
- name: Setup Python
uses: actions/setup-python@v5
with:
python-version: "3.9"
python-version: "3.10"
- name: Install nox
run: |
python -m pip install --upgrade setuptools pip wheel
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/unittest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@ on:
name: unittest
jobs:
unit:
runs-on: ubuntu-latest
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2303): use `ubuntu-latest` once this bug is fixed.
# Use ubuntu-22.04 until Python 3.7 is removed from the test matrix
# https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories
runs-on: ubuntu-22.04
strategy:
matrix:
python: ['3.7', '3.8', '3.9', '3.10', '3.11', '3.12', '3.13']
Expand Down
4 changes: 2 additions & 2 deletions google/cloud/bigtable/data/_cross_sync/_decorators.py
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,8 @@ def get_for_node(cls, node: ast.Call | ast.Attribute | ast.Name) -> "AstDecorato
# extract the module and decorator names
if "CrossSync" in ast.dump(root_attr):
decorator_name = root_attr.attr
got_kwargs = (
{kw.arg: cls._convert_ast_to_py(kw.value) for kw in node.keywords}
got_kwargs: dict[str, Any] = (
{str(kw.arg): cls._convert_ast_to_py(kw.value) for kw in node.keywords}
if hasattr(node, "keywords")
else {}
)
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/data/_async/test_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,7 @@ async def test__manage_channel_sleeps(
assert sleep.call_count == num_cycles
total_sleep = sum([call[0][1] for call in sleep.call_args_list])
assert (
abs(total_sleep - expected_sleep) < 0.1
abs(total_sleep - expected_sleep) < 0.5
), f"refresh_interval={refresh_interval}, num_cycles={num_cycles}, expected_sleep={expected_sleep}"
await client.close()

Expand Down
2 changes: 1 addition & 1 deletion tests/unit/data/_sync_autogen/test_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ def test__manage_channel_sleeps(self, refresh_interval, num_cycles, expected_sle
assert sleep.call_count == num_cycles
total_sleep = sum([call[0][1] for call in sleep.call_args_list])
assert (
abs(total_sleep - expected_sleep) < 0.1
abs(total_sleep - expected_sleep) < 0.5
), f"refresh_interval={refresh_interval}, num_cycles={num_cycles}, expected_sleep={expected_sleep}"
client.close()

Expand Down

0 comments on commit 4f60bd1

Please sign in to comment.