feat: resource tags in dataset

[keunsoopark]

• Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
• Ensure the tests and linter pass
• Code coverage does not decrease (if any source code was changed)
• Appropriate docs were updated (if necessary)

Fixes #2091 🦕

[Linchin]

Thank you so much for adding resource tags in dataset! The PR looks great overall, I just made some minor modifications. I wonder if you could add a system test, as well as a unit test for setter with None? Please let us know if you need any help. Happy holidays!

[keunsoopark]

system test

Hi @Linchin, thanks for the review.

I added system tests in system/test_clients.py

I fixed unittests for None, and added more tests for invalid values. See test_resource_tags_setter_bad_value.

Merry Christmas and happy new year!

[keunsoopark]

Got inspired from this implementation. Just took out this method to be used in both dataset & test implementation.

Do you have any tips on how to run system test locally, @Linchin? There is some setup to the actual project required, but this explanation is too vague to follow.

[Linchin]

In general you can just use pytest to run system tests, it's slightly easier than nox, and should be able to run on any python version:

pytest tests/system/test_client.py

You can specify the test class or method too:

pytest tests/system/test_client.py::TestBigQuery::test_update_dataset

This should make it faster.

[Linchin]

I think you also need to run lint, that will need to use nox:

nox -r -s lint

[keunsoopark]

Thanks I ran linting locally.

I still could not run system tests locally still. I think I need to specify GOOGLE_APPLICATION_CREDENTIALS env var (see here) anyway, but not sure what credentials I can use.
I tried to use the credentials of a service account in my personal Google Cloud project, which has a owner role in this project, but I got all PERMISSION_DENIED errors for dataset creation, table creation etc.

[Linchin]

I think if you run pytest instead of nox, you don't have to have GOOGLE_APPLICATION_CREDENTIALS set up, because we are bypassing noxfile.py.

[keunsoopark]

Ok I managed running system test locally. This is how:

• Make a python script, install_dependencies.py parsing all dependencies in specifiednoxfile.py, to install dependencies in my local pip.
• For some reason, google-cloud-testutils was not installed in this manner, as specified here, so install this one manually.
• Configure gcloud auth to my personal GCP project
• Run pytest

[keunsoopark]

Since we run multiple system tests at the same time for different Python versions, we got AlreadyExists error. We got this error only in 3.12 test, but not in 3.8 test (Does not matter on which Python version, but whatever comes later I assume).

[Linchin]

Great, thank you for fixing this!