Skip to content

deps: loosen ipywidgets range and require ipykernel in ipywidgets extra #1531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 24, 2023
Merged

deps: loosen ipywidgets range and require ipykernel in ipywidgets extra #1531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
513bfa6
fix: loosen ipywidgets restrictions further to address ipython compat…
tswast Mar 23, 2023
a2c9c88
include ipywidgets in prerelease deps
tswast Mar 23, 2023
b5d3775
show all package versions
tswast Mar 23, 2023
7c168b1
add ipykernel dependency
tswast Mar 23, 2023
f14f59a
ipykernel in noxfile
tswast Mar 23, 2023
ccc538d
oops
tswast Mar 23, 2023
7abf37f
bump min ipython
tswast Mar 23, 2023
d67f961
Merge branch 'main' into tswast-issue1530
tswast Mar 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,10 @@ def prerelease_deps(session):
session.install(
"--pre",
"--upgrade",
"IPython",
"ipykernel",
"ipywidgets",
"tqdm",
"git+https://github.com/pypa/packaging.git",
)

Expand All @@ -321,7 +325,6 @@ def prerelease_deps(session):
"google-cloud-datacatalog",
"google-cloud-storage",
"google-cloud-testutils",
"IPython",
"mock",
"psutil",
"pytest",
Expand Down Expand Up @@ -356,6 +359,7 @@ def prerelease_deps(session):
session.run("python", "-c", "import grpc; print(grpc.__version__)")
session.run("python", "-c", "import pandas; print(pandas.__version__)")
session.run("python", "-c", "import pyarrow; print(pyarrow.__version__)")
session.run("python", "-m", "pip", "freeze")

# Run all tests, except a few samples tests which require extra dependencies.
session.run("py.test", "tests/unit")
Expand Down
10 changes: 8 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,15 @@
pyarrow_dependency,
"db-dtypes>=0.3.0,<2.0.0dev",
],
"ipywidgets": ["ipywidgets>=7.7.0,<8.0.1"],
"ipywidgets": [
"ipywidgets>=7.7.0",
"ipykernel>=6.0.0",
],
"geopandas": ["geopandas>=0.9.0, <1.0dev", "Shapely>=1.8.4, <2.0dev"],
"ipython": ["ipython>=7.0.1,!=8.1.0"],
"ipython": [
"ipython>=7.23.1,!=8.1.0",
"ipykernel>=6.0.0",
],
"tqdm": ["tqdm >= 4.7.4, <5.0.0dev"],
"opentelemetry": [
"opentelemetry-api >= 1.1.0",
Expand Down
3 changes: 2 additions & 1 deletion testing/constraints-3.7.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ google-cloud-core==1.6.0
google-resumable-media==0.6.0
grpcio==1.47.0
ipywidgets==7.7.1
ipython==7.0.1
ipython==7.23.1
ipykernel==6.0.0
opentelemetry-api==1.1.0
opentelemetry-instrumentation==0.20b0
opentelemetry-sdk==1.1.0
Expand Down