remove comments

google/cloud/bigquery/_pandas_helpers.py

@@ -21,7 +21,6 @@
 import logging
 import queue
 import warnings
-from packaging import version
 
 from google.cloud.bigquery import _helpers
 
@@ -204,19 +203,14 @@ def pyarrow_timestamp():
         pyarrow.decimal128(38, scale=9).id: "NUMERIC",
     }
 
-    # if version.parse(pyarrow.__version__) >= version.parse("3.0.0"):
     BQ_TO_ARROW_SCALARS["BIGNUMERIC"] = pyarrow_bignumeric
     # The exact decimal's scale and precision are not important, as only
     # the type ID matters, and it's the same for all decimal256 instances.
     ARROW_SCALAR_IDS_TO_BQ[pyarrow.decimal256(76, scale=38).id] = "BIGNUMERIC"
-    #     # _BIGNUMERIC_SUPPORT = True
-    # else:
-    # _BIGNUMERIC_SUPPORT = False
 
 else:  # pragma: NO COVER
     BQ_TO_ARROW_SCALARS = {}  # pragma: NO COVER
     ARROW_SCALAR_IDS_TO_BQ = {}  # pragma: NO_COVER
-    # _BIGNUMERIC_SUPPORT = False  # pragma: NO COVER
 
 
 BQ_FIELD_TYPE_TO_ARROW_FIELD_METADATA = {

tests/system/test_pandas.py

@@ -380,9 +380,8 @@ def test_load_table_from_dataframe_w_nulls(bigquery_client, dataset_id):
         bigquery.SchemaField("str_col", "STRING"),
         bigquery.SchemaField("time_col", "TIME"),
         bigquery.SchemaField("ts_col", "TIMESTAMP"),
+        bigquery.SchemaField("bignum_col", "BIGNUMERIC"),
     )
-    # if _BIGNUMERIC_SUPPORT:
-    table_schema += (bigquery.SchemaField("bignum_col", "BIGNUMERIC"),)
 
     num_rows = 100
     nulls = [None] * num_rows
@@ -398,9 +397,8 @@ def test_load_table_from_dataframe_w_nulls(bigquery_client, dataset_id):
         ("str_col", nulls),
         ("time_col", nulls),
         ("ts_col", nulls),
+        ("bignum_col", nulls),
     ]
-    # if _BIGNUMERIC_SUPPORT:
-    df_data.append(("bignum_col", nulls))
     df_data = collections.OrderedDict(df_data)
     dataframe = pandas.DataFrame(df_data, columns=df_data.keys())
 
@@ -478,9 +476,8 @@ def test_load_table_from_dataframe_w_explicit_schema(bigquery_client, dataset_id
         bigquery.SchemaField("str_col", "STRING"),
         bigquery.SchemaField("time_col", "TIME"),
         bigquery.SchemaField("ts_col", "TIMESTAMP"),
+        bigquery.SchemaField("bignum_col", "BIGNUMERIC"),
     )
-    # if _BIGNUMERIC_SUPPORT:
-    table_schema += (bigquery.SchemaField("bignum_col", "BIGNUMERIC"),)
 
     df_data = [
         ("row_num", [1, 2, 3]),
@@ -524,18 +521,15 @@ def test_load_table_from_dataframe_w_explicit_schema(bigquery_client, dataset_id
                 ),
             ],
         ),
-    ]
-    # if _BIGNUMERIC_SUPPORT:
-    df_data.append(
         (
             "bignum_col",
             [
                 decimal.Decimal("-{d38}.{d38}".format(d38="9" * 38)),
                 None,
                 decimal.Decimal("{d38}.{d38}".format(d38="9" * 38)),
             ],
-        )
-    )
+        ),
+    ]
     df_data = collections.OrderedDict(df_data)
     dataframe = pandas.DataFrame(df_data, dtype="object", columns=df_data.keys())
 

tests/unit/test__pandas_helpers.py

@@ -43,7 +43,6 @@
 from google.cloud.bigquery import _helpers
 from google.cloud.bigquery import schema
 
-# from google.cloud.bigquery._pandas_helpers import _BIGNUMERIC_SUPPORT
 
 pyarrow = _helpers.PYARROW_VERSIONS.try_import()
 if pyarrow:
@@ -68,11 +67,6 @@
     # Set to less than MIN version.
     PANDAS_INSTALLED_VERSION = pkg_resources.parse_version("0.0.0")
 
-# skip_if_no_bignumeric = pytest.mark.skipif(
-#     not _BIGNUMERIC_SUPPORT,
-#     reason="BIGNUMERIC support requires pyarrow>=3.0.0",
-# )
-
 
 @pytest.fixture
 def module_under_test():
@@ -166,7 +160,6 @@ def test_all_():
             "BIGNUMERIC",
             "NULLABLE",
             is_bignumeric,
-            # marks=skip_if_no_bignumeric,
         ),
         ("BOOLEAN", "NULLABLE", pyarrow.types.is_boolean),
         ("BOOL", "NULLABLE", pyarrow.types.is_boolean),
@@ -250,7 +243,6 @@ def test_all_():
             "BIGNUMERIC",
             "REPEATED",
             all_(pyarrow.types.is_list, lambda type_: is_bignumeric(type_.value_type)),
-            # marks=skip_if_no_bignumeric,
         ),
         (
             "BOOLEAN",
@@ -372,7 +364,7 @@ def test_bq_to_arrow_data_type_w_array_struct(module_under_test, bq_type):
         schema.SchemaField("field05", "FLOAT"),
         schema.SchemaField("field06", "FLOAT64"),
         schema.SchemaField("field07", "NUMERIC"),
-        # schema.SchemaField("field08", "BIGNUMERIC"),
+        schema.SchemaField("field08", "BIGNUMERIC"),
         schema.SchemaField("field09", "BOOLEAN"),
         schema.SchemaField("field10", "BOOL"),
         schema.SchemaField("field11", "TIMESTAMP"),
@@ -381,8 +373,6 @@ def test_bq_to_arrow_data_type_w_array_struct(module_under_test, bq_type):
         schema.SchemaField("field14", "DATETIME"),
         schema.SchemaField("field15", "GEOGRAPHY"),
     )
-    # if _BIGNUMERIC_SUPPORT:
-    fields += (schema.SchemaField("field08", "BIGNUMERIC"),)
 
     field = schema.SchemaField("ignored_name", bq_type, mode="REPEATED", fields=fields)
     actual = module_under_test.bq_to_arrow_data_type(field)
@@ -395,7 +385,7 @@ def test_bq_to_arrow_data_type_w_array_struct(module_under_test, bq_type):
         pyarrow.field("field05", pyarrow.float64()),
         pyarrow.field("field06", pyarrow.float64()),
         pyarrow.field("field07", module_under_test.pyarrow_numeric()),
-        # pyarrow.field("field08", module_under_test.pyarrow_bignumeric()),
+        pyarrow.field("field08", module_under_test.pyarrow_bignumeric()),
         pyarrow.field("field09", pyarrow.bool_()),
         pyarrow.field("field10", pyarrow.bool_()),
         pyarrow.field("field11", module_under_test.pyarrow_timestamp()),
@@ -404,8 +394,6 @@ def test_bq_to_arrow_data_type_w_array_struct(module_under_test, bq_type):
         pyarrow.field("field14", module_under_test.pyarrow_datetime()),
         pyarrow.field("field15", pyarrow.string()),
     )
-    # if _BIGNUMERIC_SUPPORT:
-    expected += (pyarrow.field("field08", module_under_test.pyarrow_bignumeric()),)
     expected_value_type = pyarrow.struct(expected)
 
     assert pyarrow.types.is_list(actual)
@@ -459,7 +447,6 @@ def test_bq_to_arrow_data_type_w_struct_unknown_subfield(module_under_test):
                 decimal.Decimal("{d38}.{d38}".format(d38="9" * 38)),
                 decimal.Decimal("3.141592653589793238462643383279"),
             ],
-            # marks=skip_if_no_bignumeric,
         ),
         ("BOOLEAN", [True, None, False, None]),
         ("BOOL", [False, None, True, None]),
@@ -1036,7 +1023,7 @@ def test_dataframe_to_arrow_with_required_fields(module_under_test):
         schema.SchemaField("field05", "FLOAT", mode="REQUIRED"),
         schema.SchemaField("field06", "FLOAT64", mode="REQUIRED"),
         schema.SchemaField("field07", "NUMERIC", mode="REQUIRED"),
-        # schema.SchemaField("field08", "BIGNUMERIC", mode="REQUIRED"),
+        schema.SchemaField("field08", "BIGNUMERIC", mode="REQUIRED"),
         schema.SchemaField("field09", "BOOLEAN", mode="REQUIRED"),
         schema.SchemaField("field10", "BOOL", mode="REQUIRED"),
         schema.SchemaField("field11", "TIMESTAMP", mode="REQUIRED"),
@@ -1045,8 +1032,6 @@ def test_dataframe_to_arrow_with_required_fields(module_under_test):
         schema.SchemaField("field14", "DATETIME", mode="REQUIRED"),
         schema.SchemaField("field15", "GEOGRAPHY", mode="REQUIRED"),
     )
-    # if _BIGNUMERIC_SUPPORT:
-    bq_schema += (schema.SchemaField("field08", "BIGNUMERIC", mode="REQUIRED"),)
 
     data = {
         "field01": ["hello", "world"],
@@ -1056,10 +1041,10 @@ def test_dataframe_to_arrow_with_required_fields(module_under_test):
         "field05": [1.25, 9.75],
         "field06": [-1.75, -3.5],
         "field07": [decimal.Decimal("1.2345"), decimal.Decimal("6.7891")],
-        # "field08": [
-        #     decimal.Decimal("-{d38}.{d38}".format(d38="9" * 38)),
-        #     decimal.Decimal("{d38}.{d38}".format(d38="9" * 38)),
-        # ],
+        "field08": [
+            decimal.Decimal("-{d38}.{d38}".format(d38="9" * 38)),
+            decimal.Decimal("{d38}.{d38}".format(d38="9" * 38)),
+        ],
         "field09": [True, False],
         "field10": [False, True],
         "field11": [
@@ -1074,11 +1059,6 @@ def test_dataframe_to_arrow_with_required_fields(module_under_test):
         ],
         "field15": ["POINT(30 10)", "POLYGON ((30 10, 40 40, 20 40, 10 20, 30 10))"],
     }
-    # if _BIGNUMERIC_SUPPORT:
-    data["field08"] = [
-        decimal.Decimal("-{d38}.{d38}".format(d38="9" * 38)),
-        decimal.Decimal("{d38}.{d38}".format(d38="9" * 38)),
-    ]
     dataframe = pandas.DataFrame(data)
 
     arrow_table = module_under_test.dataframe_to_arrow(dataframe, bq_schema)
@@ -1379,12 +1359,8 @@ def test_augment_schema_type_detection_succeeds(module_under_test):
         schema.SchemaField("bytes_field", field_type=None, mode="NULLABLE"),
         schema.SchemaField("string_field", field_type=None, mode="NULLABLE"),
         schema.SchemaField("numeric_field", field_type=None, mode="NULLABLE"),
-        # schema.SchemaField("bignumeric_field", field_type=None, mode="NULLABLE"),
+        schema.SchemaField("bignumeric_field", field_type=None, mode="NULLABLE"),
     )
-    # if _BIGNUMERIC_SUPPORT:
-    current_schema += (  # type: ignore
-        schema.SchemaField("bignumeric_field", field_type=None, mode="NULLABLE"),  # type: ignore
-    )  # type: ignore
 
     with warnings.catch_warnings(record=True) as warned:
         augmented_schema = module_under_test.augment_schema(dataframe, current_schema)
@@ -1406,12 +1382,6 @@ def test_augment_schema_type_detection_succeeds(module_under_test):
         schema.SchemaField("bytes_field", field_type="BYTES", mode="NULLABLE"),
         schema.SchemaField("string_field", field_type="STRING", mode="NULLABLE"),
         schema.SchemaField("numeric_field", field_type="NUMERIC", mode="NULLABLE"),
-        # schema.SchemaField(
-        #     "bignumeric_field", field_type="BIGNUMERIC", mode="NULLABLE"
-        # ),
-    )
-    # if _BIGNUMERIC_SUPPORT:
-    expected_schema += (
         schema.SchemaField(
             "bignumeric_field", field_type="BIGNUMERIC", mode="NULLABLE"
         ),