Skip to content

chore: sort imports #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 24, 2024
Merged

chore: sort imports #770

merged 5 commits into from
May 24, 2024

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented May 16, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

🦕

@tswast tswast requested review from a team as code owners May 16, 2024 22:25
@tswast tswast requested review from gericdong and mrfaizal May 16, 2024 22:25
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label May 16, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-pandas API. label May 16, 2024
@tswast tswast requested review from chalmerlowe and removed request for mrfaizal and gericdong May 20, 2024 20:58
@Linchin
Copy link
Contributor

Linchin commented May 21, 2024

Thanks, was this a change by lint?

@tswast tswast added the automerge Merge the pull request once unit tests and other checks pass. label May 24, 2024
@tswast
Copy link
Collaborator Author

tswast commented May 24, 2024

Thanks, was this a change by lint?

Yes. I ran nox -s format and added that to owlbot.py to keep it intact.

@gcf-merge-on-green gcf-merge-on-green bot merged commit 631532c into main May 24, 2024
25 of 26 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the import-order branch May 24, 2024 15:52
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-pandas API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants