Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: accepts a table ID, which downloads the table without a query #443

Merged
merged 22 commits into from
Dec 22, 2021
Merged

feat: accepts a table ID, which downloads the table without a query #443

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
9a9d3fd
feat: accepts a table ID, which downloads the table without a query
tswast Dec 6, 2021
6adf233
add todo for next steps
tswast Dec 6, 2021
73a791a
Merge remote-tracking branch 'upstream/main' into issue266-read_gbq-n…
tswast Dec 9, 2021
9b1eb0d
add unit test for table ID read_gbq
tswast Dec 9, 2021
ec9ddaf
add helper for is_query
tswast Dec 9, 2021
9cc7c74
implement read_gbq with table id
tswast Dec 10, 2021
dd51ad8
fix remaining tests, don't localalize out-of-bounds timestamp columns
tswast Dec 10, 2021
e1ad679
Update pandas_gbq/gbq.py
tswast Dec 10, 2021
d29bc2a
fix 3.7 unit tests
tswast Dec 10, 2021
cb8f24f
correct coverage
tswast Dec 10, 2021
56b73b2
skip coverage for optional test skip
tswast Dec 10, 2021
8a61e97
fix docs build
tswast Dec 10, 2021
3f7900b
improve test coverage for error case
tswast Dec 10, 2021
3c53f1f
as of google-cloud-bigquery 1.11.0, get_table before list_rows is unn…
tswast Dec 13, 2021
5ce125f
tests with whitespace
tswast Dec 20, 2021
ea660f4
type annotations
tswast Dec 20, 2021
6704991
improve coverage in owlbot config
tswast Dec 20, 2021
9a1ca16
🦉 Updates from OwlBot
gcf-owl-bot[bot] Dec 20, 2021
a9075df
boost coverage
tswast Dec 21, 2021
b3061b6
Merge branch 'issue266-read_gbq-no-query' of github.com:tswast/python…
tswast Dec 22, 2021
ed3f9d9
Revert "boost coverage"
tswast Dec 22, 2021
b9b017c
don't cover type checking only code, more generic type annotation
tswast Dec 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions pandas_gbq/gbq.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,17 @@
import time
import warnings
from datetime import datetime
import typing
from typing import Dict, Optional, Union

import numpy as np

# Only import at module-level at type checking time to avoid circular
# dependencies in the pandas package, which has an optional dependency on
# pandas-gbq.
if typing.TYPE_CHECKING:
import pandas
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will never be executed during the tests (TYPE_CHECKING is False at runtime), thus at some point coverage will complain. Let's add a # pragma: NO COVER comment to ignore this block.


# Required dependencies, but treat as optional so that _test_google_api_imports
# can provide a better error message.
try:
Expand Down Expand Up @@ -380,8 +388,14 @@ def process_http_error(ex):
raise GenericGBQException("Reason: {0}".format(ex))

def download_table(
self, table_id, max_results=None, progress_bar_type=None, dtypes=None
):
self,
table_id: str,
max_results: Optional[int] = None,
progress_bar_type: Optional[str] = None,
dtypes: Dict[
str, Union[str, "pandas.api.extensions.ExtensionDtype", np.dtype]
] = None,
) -> "pandas.DataFrame":
self._start_timer()

try:
Expand Down