Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use faster query_and_wait method when available to skip BQ Storage API if all query results are already available #710

Closed
tswast opened this issue Dec 8, 2023 · 0 comments · Fixed by #722
Assignees
Labels
api: bigquery Issues related to the googleapis/python-bigquery-pandas API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@tswast
Copy link
Collaborator

tswast commented Dec 8, 2023

Similar to googleapis/python-bigquery#1745, pandas-gbq should benefit from the optimizations done in googleapis/python-bigquery#589.

This might require a progress bar feature in query_and_wait if we want to keep the progress bar for waiting for the query to finish, but we need to be careful when introducing such a progress bar to avoid timing out API requests too soon.

@tswast tswast self-assigned this Dec 8, 2023
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-pandas API. label Dec 8, 2023
@tswast tswast added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Dec 8, 2023
gcf-merge-on-green bot pushed a commit that referenced this issue Jan 16, 2024
This prepares the way for using the `query_and_wait` method built-in to the client library when available.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/python-bigquery-pandas/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Towards #710 
🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-pandas API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
1 participant