-
Notifications
You must be signed in to change notification settings - Fork 5
Open
Labels
api: bigqueryIssues related to the googleapis/python-bigquery-magics API.Issues related to the googleapis/python-bigquery-magics API.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.
Description
hi @aribray, looks like the issue is now solved! Thank you very much for that.
I only have one nitpick regarding the new progress bar setup: it's a bit weird to have two progress bars, and one of them is pushed to the right when the job ID appears:
I suppose it would be better to have just a single progress bar on its own line (job ID should be its own line too).
If you want to make the output more complete, I've been also showing the data processed at the very end in my own bigquery magic like this:
from humanize.filesize import naturalsize
...
if args.info:
processed = naturalsize(query.total_bytes_processed)
display(ipywidgets.HTML(value='Data processed: ' + (
f'<b>{processed}</b>' if not query.cache_hit
else 'none <b>(returned from cache)</b>'
)))
With this addition the output looks like this:
It might look better if you add a colon after the "Job ID" too, but that's just my subjective preference.
Originally posted by @GergelyKalmar in googleapis/python-bigquery#1146 (comment)
GergelyKalmar
Metadata
Metadata
Assignees
Labels
api: bigqueryIssues related to the googleapis/python-bigquery-magics API.Issues related to the googleapis/python-bigquery-magics API.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.

