feat: copy pandas matplotlib code to third_party #409
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xl
Wondering why we can't depend on them directly through package dependency? |
@shobsi It can avoid tight dependency on pandas internal classes to ensure long-term compatibility. Pandas only tries to guarantees stability only for its public API, but not for these internal classes. |
chelsea-lin
force-pushed
the
main_chelsealin_plothist0
branch
from
4aaad78 to
a65cb35
Compare
|
We don't need this PR anymore with the change: #420 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change copies the pandas
MPLPlotandLinePlotclasses to thethird_partyfolder, in preparation for implements to theplot.histfeatures (internal bug: b/322178004)