refactor: fix and, or and xor ops on NULL scalar#2361
Merged
chelsea-lin merged 2 commits intomainfrom Jan 6, 2026
Merged
Conversation
product-auto-label
bot
added
size: m
chelsea-lin
force-pushed
the
main_chelsealin_and
branch
2 times, most recently
from
3f285f8 to
2b70459
Compare
jialuoo
reviewed
Jan 2, 2026
| right_expr = sge.Cast(this=sge.convert(None), to="BOOLEAN") | ||
| right_dtype = dtypes.BOOL_DTYPE | ||
|
|
||
| if left_dtype == dtypes.BOOL_DTYPE and right_dtype == dtypes.BOOL_DTYPE: |
Contributor
There was a problem hiding this comment.
Suggestion: write comments for this logic here.
Contributor
Author
There was a problem hiding this comment.
good points. fixed. thanks!
chelsea-lin
force-pushed
the
main_chelsealin_and
branch
from
2b70459 to
cd4af89
Compare
jialuoo
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change can resolve
test_series_bool_bool_operators_scalarandtest_series_int_int_operators_scalarpresubmit failures in #2248.Fixes internal issue 417774347🦕