Skip to content

Conversation

@ccarpentiere
Copy link
Collaborator

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass.
  • [N/A] Code coverage does not decrease (if any source code was changed)
  • [N/A] Appropriate docs were updated (if necessary)

Fixes #2000 🦕

Unit tests for Python 3.12 passed, notebook works when tested in the console.

@ccarpentiere ccarpentiere requested review from a team as code owners August 18, 2025 20:16
@ccarpentiere ccarpentiere requested a review from jialuoo August 18, 2025 20:16
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Aug 18, 2025
@ccarpentiere ccarpentiere requested a review from tswast August 18, 2025 20:19
@ccarpentiere ccarpentiere changed the title Update bq_dataframes_llm_output_schema.ipynb docs: update bq_dataframes_llm_output_schema.ipynb Aug 18, 2025
@ccarpentiere ccarpentiere requested a review from sycai August 18, 2025 20:39
" </a>\n",
" </td>\n",
" <td>\n",
" <a href=\"https://github.com/googleapis/python-bigquery-dataframes/blob/main/notebooks/generative_ai/bq_dataframes_llm_output_schema.ipynb\">\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should use a Vertext AI Workbench link instead of a Github link?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had added that option in, and I just removed it again. It isn't really needed, since we want users to open the notebook in BigQuery.

@tswast tswast enabled auto-merge (squash) October 30, 2025 21:42
@tswast tswast added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 31, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 31, 2025
@tswast tswast merged commit 316ba9f into googleapis:main Oct 31, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edit bq_dataframes_llm_output_schema.ipynb for clarity and completeness

5 participants