feat: Add experimental polars execution #1747
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
TrevorBergeron
force-pushed
the
polars_semi
branch
from
b733f2e to
5449696
Compare
tswast
reviewed
Jun 17, 2025
| @@ -94,6 +94,7 @@ def __init__( | |||
| requests_transport_adapters: Sequence[ | |||
| Tuple[str, requests.adapters.BaseAdapter] | |||
| ] = (), | |||
| enable_polars_execution: bool = False, | |||
There was a problem hiding this comment.
Should this be a compute option so it can be changed at runtime?
There was a problem hiding this comment.
Kind of just want to keep it as a constant within-session for now (will need to commit if making this a GA feature though). Turning polars execution on and off mid-session will make things like caching, multi-part execution really tricky
tswast
reviewed
Jun 17, 2025
|
|
||
| @enable_polars_execution.setter | ||
| def enable_polars_execution(self, value: bool): | ||
| if value is True: |
There was a problem hiding this comment.
The setter might also be an opportune time to check that polars is installed and a compatible version.
There was a problem hiding this comment.
Added a util to check version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕