-
Notifications
You must be signed in to change notification settings - Fork 50
perf: Fold row count ops when known #1656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
83aeb4f
perf: Fold row count ops when known
TrevorBergeron 73314f9
Merge remote-tracking branch 'github/main' into fold_len
TrevorBergeron 50265b0
safer pruning
TrevorBergeron daae16a
use direct head expr schema to retrieve_repr
TrevorBergeron 79f022e
fix fields for ResultNode
TrevorBergeron ca643f4
internalize pandas conversion to result object
TrevorBergeron 9e505c0
fix semi executor output ids
TrevorBergeron 89dd21b
mypy
TrevorBergeron 9fb19dc
fix rename_columns usage for old pyarrow
TrevorBergeron c516244
Merge remote-tracking branch 'github/main' into fold_len
TrevorBergeron File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
# Copyright 2025 Google LLC | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
from __future__ import annotations | ||
|
||
import pyarrow as pa | ||
|
||
from bigframes import dtypes | ||
from bigframes.core import local_data, nodes | ||
from bigframes.operations import aggregations | ||
|
||
|
||
def fold_row_counts(node: nodes.BigFrameNode) -> nodes.BigFrameNode: | ||
if not isinstance(node, nodes.AggregateNode): | ||
return node | ||
if len(node.by_column_ids) > 0: | ||
return node | ||
if node.child.row_count is None: | ||
return node | ||
for agg, _ in node.aggregations: | ||
if agg.op != aggregations.size_op: | ||
return node | ||
local_data_source = local_data.ManagedArrowTable.from_pyarrow( | ||
pa.table({"count": pa.array([node.child.row_count], type=pa.int64())}) | ||
) | ||
scan_list = nodes.ScanList( | ||
tuple( | ||
nodes.ScanItem(out_id, dtypes.INT_DTYPE, "count") | ||
for _, out_id in node.aggregations | ||
) | ||
) | ||
return nodes.ReadLocalNode( | ||
local_data_source=local_data_source, scan_list=scan_list, session=node.session | ||
) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A naming suggestion for this module: I think we can name the file as "row_counts"
The good thing is that if you want to add more re-write functions for row_counts in the future, they will all look like this
row_counts.expand(..)
,row_counts.reverse(...)
, which keeps the code organized.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fold_row_count
isn't the module though,core.compile.rewrite
is. For now this file just defines a single symbol, so figure best to be as precise as possible? Easy enough to change later if add more to this file.