fix: add retry for test_clean_up_via_context_manager #1627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xs
sycai
added
the
kokoro:force-run
bigframes-bot
removed
kokoro:force-run
shobsi
reviewed
Apr 18, 2025
| @@ -151,6 +151,7 @@ def test_clean_up_by_session_id(): | |||
| pytest.param(bigframes.connect, id="connect-method"), | |||
| ], | |||
| ) | |||
| @pytest.mark.flaky(retries=3) | |||
There was a problem hiding this comment.
Curious what flakiness we ran into.. quota issue?
There was a problem hiding this comment.
Feels like something about server latency: b/411420369
Example error: https://fusion2.corp.google.com/invocations/8f00eb76-d4fd-4c84-899d-5fbf2645e44c/targets/bigframes%2Fcontinuous%2Fe2e/log
shobsi
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.