-
Notifications
You must be signed in to change notification settings - Fork 49
chore: show FutureWarning
for LEP endpoints usage with use_regional_endpoints=True
#1432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Warning You have reached your daily quota limit. As a reminder, free tier users are limited to 5 requests per day. Please wait up to 24 hours and I will start processing your requests again! |
bigframes/exceptions.py
Outdated
class DeprecationWarning(Warning): | ||
"""The functionality or support is being deprecated.""" | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The built-in FutureWarning
from Python is intended to be used for this purpose.
class DeprecationWarning(Warning): | |
"""The functionality or support is being deprecated.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed, thanks!
bigframes/session/clients.py
Outdated
bigframes.constants.LEP_DEPRECATION_WARNING_MESSAGE.format( | ||
location=location | ||
), | ||
category=bigframes.exceptions.DeprecationWarning, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use the built-in FutureWarning
.
category=bigframes.exceptions.DeprecationWarning, | |
category=FutureWarning, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, thanks!
DeprecationWarning
for LEP endpoints usageclient_endpoints_override
over use_regional_endpoints
if both are provided, show FutureWarning
for LEP endpoints usage
…g is disabled by default" This reverts commit faa3050.
client_endpoints_override
over use_regional_endpoints
if both are provided, show FutureWarning
for LEP endpoints usageFutureWarning
for LEP endpoints usage with use_regional_endpoints=True
FutureWarning
for LEP endpoints usage with use_regional_endpoints=True
FutureWarning
for LEP endpoints usage with use_regional_endpoints=True
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes internal issue 399101005 🦕