chore: require Python ≥ 3.9, protobuf ≥ 4.25.8 #877

vchudnov-g · 2025-12-04T19:54:33Z

Require Python 3.9+
Require protobuf 4.25.8+
Corollary for test coverage:

Update google-auth ≥ 2.35.0, < 3.0.0
Update requests ≥ 2.20.0, < 3.0.0
Update googleapis-common-protos ≥ 1.56.3, < 2.0.0

Simplify code accordingly.

Fixes #835

This also required removing 3.7 and 3.8 as required checks in the repo config, under branch protection rules.

gemini-code-assist · 2025-12-04T19:54:57Z

Summary of Changes

Hello @vchudnov-g, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the project's development and testing environment by officially ending support for Python 3.7 and 3.8. It updates various configuration files and removes legacy CI setups, aligning the project with Python 3.9 as the new minimum required version, ensuring compatibility with modern Python features and dependencies.

Highlights

Python Version Support: This pull request officially drops support for Python 3.7 and 3.8, aligning the project with newer Python versions.
Configuration Updates: Project configuration files, including pyproject.toml and setup.cfg, have been updated to reflect Python 3.9 as the new minimum required version.
CI/Testing Streamlining: Continuous Integration (CI) configurations and testing constraints specific to Python 3.7 and 3.8 have been removed, and Nox test sessions updated, to streamline the testing pipeline.

Ignored Files

Ignored by pattern: .github/workflows/** (1)
- .github/workflows/unittest.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request correctly removes support for Python 3.7 and 3.8 by updating configuration files, dependencies, and CI scripts. The changes are clean and directly address the goal of the PR. I have one suggestion in tests/asyncio/test_operation_async.py to improve the correctness of a test that was modified.

tests/asyncio/test_operation_async.py

This is in response to a code review comment by Gemini Code Assist

vchudnov-g · 2025-12-05T17:42:49Z

/gemini review

gemini-code-assist

Code Review

This pull request correctly removes support for Python 3.7 and 3.8. The changes are consistent across the codebase, including updating CI configurations, Python version specifiers in pyproject.toml and noxfile.py, and removing dependencies that were only necessary for the older Python versions. The modifications are well-executed and align with the PR's goal. As a follow-up, you could also remove the importlib_metadata dependency from pyproject.toml (lines 53-55), as it's a backport for Python versions older than 3.8 and is no longer needed.

vchudnov-g · 2025-12-06T00:06:33Z

Marking this ready for review. Do not merge until we have an analogous PR ready for gapic-generator-python.

Still trying to figure out why the test coverage went down in areas that should not have been affected. I welcome any ideas.

daniel-sanche · 2025-12-06T00:29:30Z

google/api_core/gapic_v1/method.py

    # https://stackoverflow.com/a/60605919/101923
-    #
-    # Literal[_DEFAULT_VALUE] is an alternative, but only added in Python 3.8.
-    # https://docs.python.org/3/library/typing.html#typing.Literal


it looks like this comment is saying an improvement is available to us now that we're dropping 3.7. Is that something we'd want to consider, or should we stick with the existing implementation?

I looked at this and it didn't seem like a cleaner alternative. I'm not sure what I had in mind when I first wrote this comment, but I think the current implementation is clean.

daniel-sanche · 2025-12-06T00:33:45Z

pyproject.toml

  # Remove once https://github.com/grpc/grpc/issues/35086 is fixed (and version newer than 1.60.0 is published)
  "ignore:There is no current event loop:DeprecationWarning",
-  # Remove after support for Python 3.7 is dropped
-  "ignore:After January 1, 2024, new releases of this library will drop support for Python 3.7:DeprecationWarning",


maybe we should keep in a generic version of this warning, since we expect to start seeing it for other versions at some point in the future

All the warnings issued by _python_version_support.py are of type FutureWarning, which are captured by the rule above.

This particular configuration line was brought in from pytest.ini during the migration to TOML (#736) before we had the current Python version warnings

… version tests

See https://github.com/googleapis/google-cloud-python/commits/main/packages/googleapis-common-protos/pyproject.toml

vchudnov-g

Fixed the coverage issue; it was due to the 3.9 tests coverage file. Thanks, @daniel-sanche !

PTAL

vchudnov-g · 2025-12-08T21:21:52Z

google/api_core/gapic_v1/method.py

    # https://stackoverflow.com/a/60605919/101923
-    #
-    # Literal[_DEFAULT_VALUE] is an alternative, but only added in Python 3.8.
-    # https://docs.python.org/3/library/typing.html#typing.Literal


I looked at this and it didn't seem like a cleaner alternative. I'm not sure what I had in mind when I first wrote this comment, but I think the current implementation is clean.

vchudnov-g · 2025-12-08T21:35:28Z

pyproject.toml

  # Remove once https://github.com/grpc/grpc/issues/35086 is fixed (and version newer than 1.60.0 is published)
  "ignore:There is no current event loop:DeprecationWarning",
-  # Remove after support for Python 3.7 is dropped
-  "ignore:After January 1, 2024, new releases of this library will drop support for Python 3.7:DeprecationWarning",


All the warnings issued by _python_version_support.py are of type FutureWarning, which are captured by the rule above.

This particular configuration line was brought in from pytest.ini during the migration to TOML (#736) before we had the current Python version warnings

daniel-sanche

LGTM

product-auto-label bot added size: m Pull request size is medium. samples Issues that are directly related to samples. labels Dec 4, 2025

gemini-code-assist bot reviewed Dec 4, 2025

View reviewed changes

tests/asyncio/test_operation_async.py Show resolved Hide resolved

chore: remove support for Python 3.7 and 3.8

345ed00

vchudnov-g force-pushed the py-drop-3 branch from be42019 to 345ed00 Compare December 4, 2025 22:41

vchudnov-g added 3 commits December 4, 2025 15:21

chore: format

e7d5849

fix nox -s prerelease_deps by adding dependencies to noxfile

00bacfc

chore: Use async mock in async test

d91d4b1

This is in response to a code review comment by Gemini Code Assist

gemini-code-assist bot reviewed Dec 5, 2025

View reviewed changes

vchudnov-g added 3 commits December 5, 2025 10:08

chore: Simplify code intended for Python 3.9+

063991a

chore: remove unused import

e6ab415

chore:remove unused import; cosmetic

fa50b6a

product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Dec 5, 2025

vchudnov-g added 7 commits December 5, 2025 10:25

exclude coverage calculations on some exceptional lines

02bdd5d

fix coverage: runder under proto 4.x

e420f47

test(proto-4.25.8): Fix to run on supported Python version (3.11)

6c2206c

Have nox run the legacy protobuf test

f9f4e7f

fix coverage file names

cf8c92a

don't worry about covering unit test

90cff72

Cover legacy protobuf tests

39992e3

vchudnov-g force-pushed the py-drop-3 branch from 11fb15f to a2a4bde Compare December 5, 2025 22:54

fix session skip in test

fb410f4

vchudnov-g force-pushed the py-drop-3 branch 2 times, most recently from af514f3 to fb410f4 Compare December 5, 2025 23:35

vchudnov-g added 2 commits December 5, 2025 15:42

chore: require protobuf ≥ 4.25.8

371d27e

feat: warn users of upcoming minimum protobuf 5.0.0 requirement

f9ce257

vchudnov-g changed the title ~~chore: remove support for Python 3.7 and 3.8~~ chore: require Python ≥ 3.9, protobuf ≥ 4.25.8 Dec 6, 2025

vchudnov-g added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 6, 2025

vchudnov-g requested review from daniel-sanche and parthea December 6, 2025 00:07

vchudnov-g marked this pull request as ready for review December 6, 2025 00:07

vchudnov-g requested review from a team as code owners December 6, 2025 00:07

blunderbuss-gcf bot assigned ohmayr Dec 6, 2025

vchudnov-g unassigned ohmayr Dec 6, 2025

daniel-sanche reviewed Dec 6, 2025

View reviewed changes

vchudnov-g added 4 commits December 8, 2025 11:01

chore: Pin depencies to lower bounds in constraints for lowest Python…

2a57035

… version tests

chore: bumpgoogleapis-common-protos to vbersion supporting protobuf 4.x

0f9589e

See https://github.com/googleapis/google-cloud-python/commits/main/packages/googleapis-common-protos/pyproject.toml

chjore: Update minimum version of google-auth to 2.35.0

f4decd5

chore: require requests ≥ 2.20.0

c506726

vchudnov-g commented Dec 8, 2025

View reviewed changes

blunderbuss-gcf bot assigned parthea Dec 8, 2025

vchudnov-g added 3 commits December 8, 2025 13:47

chore: try removing NO COVER pragmas

5ebe08d

restore one NO COVER pragma

fe43df7

clean up removed pragmas

b1b5822

daniel-sanche approved these changes Dec 8, 2025

View reviewed changes

chore: require Python ≥ 3.9, protobuf ≥ 4.25.8 #877

Are you sure you want to change the base?

chore: require Python ≥ 3.9, protobuf ≥ 4.25.8 #877

Uh oh!

Conversation

vchudnov-g commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Dec 4, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

vchudnov-g commented Dec 5, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

vchudnov-g commented Dec 6, 2025

Uh oh!

daniel-sanche Dec 6, 2025

Choose a reason for hiding this comment

Uh oh!

vchudnov-g Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

daniel-sanche Dec 6, 2025

Choose a reason for hiding this comment

Uh oh!

vchudnov-g Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

vchudnov-g left a comment

Choose a reason for hiding this comment

Uh oh!

vchudnov-g Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

vchudnov-g Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

daniel-sanche left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vchudnov-g commented Dec 4, 2025 •

edited

Loading