chore: bump minimum version of protobuf to 4.25.8 #839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohmayr
changed the title
product-auto-label
bot
added
size: l
ohmayr
force-pushed
the
bump-protobuf-version
branch
from
87faed2 to
c625a66
Compare
|
Do not merge yet. We want to merge and release #832 before we increase the minimum versions of Python and of protobuf. |
vchudnov-g
added
the
do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps the minimum version of Protobuf to
4.25.8to address the security vulnerability in Protobuf < 4.x.This means that we're also removing dependency on
grpc_gcpandgrpcio_gcpwhich are needed for Protobuf < 4.x.This PR also drops support for Python 3.7 since it is not supported by Protobuf 4.25.8.
Note: Bumping the major version could introduce diamond dependency, and we don't expect users to be impacted because
grpcio-gcpis only supported in protobuf 3.x and users of protobuf 3.x would not be able to install the latest version of the library.