feat: if user_agent set in gapic ClientInfo, populate the user-agent header
#750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
tswast
commented
Oct 30, 2024
| return (METRICS_METADATA_KEY, self.to_user_agent()) | ||
|
|
||
| user_agent = self.to_user_agent() | ||
| metadata = [ |
There was a problem hiding this comment.
We need to be careful with this. Per googleapis/gapic-generator-python#911 it looks like some code might rely on to_grpc_metadata returning a Tuple.
Might be best to introduce a new method to return the list of metadata
|
Closing as I haven't been able to reproduce the issue in b/344836155. Let's continue the discussion internally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Follow-up to internal issues 352042662 and 351894828.
Related to sdk request 344836155.
🦕