fix: store prefetched exceptions #733
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@daniel-sanche SG. Please assign back once tests are added and presubmits are green |
product-auto-label
bot
added
size: s
daniel-sanche
commented
Oct 9, 2024
google/api_core/grpc_helpers.py
Outdated
| elif hasattr(self, "_stored_first_error"): | ||
| exc = self._stored_first_error | ||
| del self._stored_first_error | ||
| raise exc |
There was a problem hiding this comment.
I'm considering whether it's worth refactoring both these variables, so we don't have to do two hasattr lookups for each stream result. For now I'm just following the existing code though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issues with pre-fetching streams not being retried when they should be
More context in attached bug
Fixes: #731
Will add tests if there are no objections to the change