Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fail gracefully if could not import rpc_status module #680

Merged
merged 5 commits into from
Aug 7, 2024

Conversation

NickGoog
Copy link
Contributor

Fail gracefully if could not import rpc_status module.

Fixes #659 🦕

@NickGoog NickGoog requested review from a team as code owners July 29, 2024 16:44
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jul 29, 2024
@NickGoog NickGoog changed the title Update exceptions.py Fail gracefully if could not import rpc_status module. Jul 29, 2024
Copy link

conventional-commit-lint-gcf bot commented Jul 29, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@parthea parthea changed the title Fail gracefully if could not import rpc_status module. fix: Fail gracefully if could not import rpc_status module Jul 29, 2024
@NickGoog NickGoog force-pushed the patch-1 branch 3 times, most recently from 9f7bbec to 93efce3 Compare July 30, 2024 13:34
@parthea parthea assigned parthea and unassigned ohmayr Aug 1, 2024
@parthea
Copy link
Collaborator

parthea commented Aug 1, 2024

I'm looking into the failing coverage check
https://github.com/googleapis/python-api-core/actions/runs/10200237862/job/28219271887

@parthea parthea enabled auto-merge (squash) August 7, 2024 16:32
@parthea parthea merged commit 7ccbf57 into googleapis:main Aug 7, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'NoneType' object has no attribute 'from_call'
3 participants