Skip to content
This repository was archived by the owner on Jul 20, 2023. It is now read-only.

chore(samples): removing migrated samples #1083

Merged
merged 13 commits into from
Jan 13, 2023
Merged

chore(samples): removing migrated samples #1083

merged 13 commits into from
Jan 13, 2023

Conversation

@telpirion
Copy link
Contributor

@telpirion telpirion requested review from a team as code owners December 12, 2022 20:50
@snippet-bot
Copy link

snippet-bot bot commented Dec 12, 2022 •
edited
Loading

Here is the summary of changes.

You are about to delete 62 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@generated-files-bot
Copy link

generated-files-bot bot commented Dec 12, 2022 •
edited
Loading

Warning: This pull request is touching the following templated files:

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: vision Issues related to the googleapis/nodejs-vision API. samples Issues that are directly related to samples. labels Dec 12, 2022
@meredithslota
Copy link
Contributor

I just clicked the box to refresh the comment from SnippetBot — I want to make sure we resolve all instances of samples in use safely so we don't end up with broken links. Are all CLs related to this migration merged?

@meredithslota meredithslota added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 12, 2023
@meredithslota
Copy link
Contributor

Sent cl/501606662 to address the vision_set_endpoint in the local variables file first since it'll propagate to other pages.

@meredithslota
Copy link
Contributor

Sent cl/501614555 to address the remaining region_tag updates. Let's wait for these to be merged and for SnippetBot to be happy before deleting these.

@meredithslota meredithslota self-assigned this Jan 12, 2023
@meredithslota
Copy link
Contributor

Both CLs are submitted, just waiting for the SnippetBot index to pick up changes and make sure I didn't miss any.

@meredithslota
Copy link
Contributor

Ok, looks like I missed two region tags somewhere, so will send another CL updating those. Stay tuned. :)

@meredithslota
Copy link
Contributor

Sent cl/501719994.

@meredithslota
Copy link
Contributor

Ok, last CL has been submitted, just waiting for SnippetBot index to update. The samples test is failing (expected) so I think we also might want to remove the samples tests in this PR (or, ok to merge as-is and remove the tests in a follow-up PR).

@meredithslota
Copy link
Contributor

SnippetBot is happy! Removing the do not merge label and it's ok to ignore the samples test failure.

@meredithslota meredithslota removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 13, 2023
@telpirion telpirion merged commit 4d5c0ca into main Jan 13, 2023
@telpirion telpirion deleted the delete-samples branch January 13, 2023 22:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@meredithslota meredithslota meredithslota approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@meredithslota meredithslota

Labels

api: vision Issues related to the googleapis/nodejs-vision API. samples Issues that are directly related to samples. size: xl Pull request size is extra large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@telpirion @meredithslota