Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce v4 signed url #637

Merged
merged 83 commits into from
Apr 4, 2019
Merged
Show file tree
Hide file tree
Changes from 68 commits
Commits
Show all changes
83 commits
Select commit Hold shift + click to select a range
e049fd4
feat: v4 signed url WIP
jkwlui Mar 11, 2019
c12ba4d
make version an optinoal
jkwlui Mar 13, 2019
693b2d2
lint
jkwlui Mar 13, 2019
d52b323
add required host header
jkwlui Mar 15, 2019
9f9942f
Merge branch 'master' into v4-signedurl
jkwlui Mar 15, 2019
a1ea350
fix canonical query params joining
jkwlui Mar 15, 2019
45d2945
add test for defaulting to v2
jkwlui Mar 18, 2019
329ccbc
fix v4 signing with test
jkwlui Mar 18, 2019
4f5f99d
fix tests
jkwlui Mar 18, 2019
e468186
refactor post-signing url construction v2/v4
jkwlui Mar 20, 2019
bafd91a
add v4 tests: response-content-type and generate parameters
jkwlui Mar 20, 2019
db4069e
convert signature to HEX
jkwlui Mar 21, 2019
3822b50
add conformance test
jkwlui Mar 22, 2019
33c83fe
npm run fix
jkwlui Mar 22, 2019
910d438
remove reduntant toLowerCase
jkwlui Mar 22, 2019
d67c481
do not promisify getDate()
jkwlui Mar 22, 2019
a97de76
add system-test for v4 signing
jkwlui Mar 22, 2019
fc983ff
run conformance test along with system test
jkwlui Mar 22, 2019
e123248
fix tests
jkwlui Mar 22, 2019
73923bb
add content-md5 and content-type to signed headers if given
jkwlui Mar 22, 2019
fa954bc
Merge branch 'master' into v4-signedurl
jkwlui Mar 22, 2019
ad897a8
Object.entries in not ES5
jkwlui Mar 22, 2019
3094dd8
Merge branch 'v4-signedurl' of github.com:googleapis/nodejs-storage i…
jkwlui Mar 22, 2019
2e49d8e
npm run fix
jkwlui Mar 22, 2019
ce00255
split out conformance test
jkwlui Mar 22, 2019
c99f0e3
test: invalid version param given
jkwlui Mar 22, 2019
dcb9ac6
mock out Date when testing instead of override Date
jkwlui Mar 25, 2019
23d787f
use Array.map to build canonical query
jkwlui Mar 25, 2019
a4999da
refactor: use dateformat library instead of writing a function
jkwlui Mar 25, 2019
0f90f87
refactor: remove unused
jkwlui Mar 25, 2019
03f22e9
remove reference to deleted methods
jkwlui Mar 25, 2019
4f4335a
Merge branch 'master' into v4-signedurl
jkwlui Mar 25, 2019
1f09d84
refactor: use string interpolation and dot accessor
jkwlui Mar 25, 2019
157e1d4
refactor: use method chaining
jkwlui Mar 25, 2019
cc18d50
Merge branch 'v4-signedurl' of github.com:googleapis/nodejs-storage i…
jkwlui Mar 25, 2019
c75ba60
add a comment about singled valued header
jkwlui Mar 25, 2019
8d8856b
refactor signedHeaders
jkwlui Mar 25, 2019
6d8ac76
Number(x)
jkwlui Mar 25, 2019
6d975a4
refactor: use query-string module as url.parse is deprecated
jkwlui Mar 26, 2019
3471e07
npm run fix
jkwlui Mar 26, 2019
fe70dee
use query-string to build canonicalQueryParams
jkwlui Mar 26, 2019
3b5e3ca
refactor: verb => method
jkwlui Mar 26, 2019
b1ee727
Merge branch 'master' into v4-signedurl
jkwlui Mar 26, 2019
6da70ba
refactor: use sinon.FakeTimers instead of timekeeper
jkwlui Mar 26, 2019
7b68f8b
npm run fix
jkwlui Mar 26, 2019
5c4c456
use async/await for new system-test
jkwlui Mar 26, 2019
5a83d9a
use async/await for new test (2)
jkwlui Mar 26, 2019
c74656b
convert getSignedUrl tests to async/await
jkwlui Mar 26, 2019
9de9171
refactor: correctly filter out undefined header values
jkwlui Mar 26, 2019
1f683e9
npm run fix
jkwlui Mar 26, 2019
6bcc8bc
make v4 multi-valued header delimiter consistent with v2, (single `,`…
jkwlui Mar 26, 2019
ee1ceb2
Merge branch 'master' into v4-signedurl
jkwlui Mar 27, 2019
96ecb7b
copy stack trace
jkwlui Mar 27, 2019
487b344
fix: replace ALL sequential spaces
jkwlui Mar 27, 2019
fca30d3
OutgoingHttpHeaders use generic type .map; rename flattenObject => ob…
jkwlui Mar 27, 2019
88a2feb
refactor: use build-in querystring
jkwlui Mar 27, 2019
41211fb
break up v2/v4 signed url query interface
jkwlui Mar 27, 2019
d1b3015
add comments about the construction of canonical headers
jkwlui Mar 27, 2019
bcc64d8
Merge branch 'master' into v4-signedurl
jkwlui Mar 27, 2019
d55b766
npm run fix
jkwlui Mar 27, 2019
f352a4f
Merge branch 'v4-signedurl' of github.com:googleapis/nodejs-storage i…
jkwlui Mar 27, 2019
a58f56c
git merge failed to put code in right place
jkwlui Mar 27, 2019
e932097
test: assert SigningError thrown
jkwlui Mar 27, 2019
83a8c8b
test(v4): resumable upload
jkwlui Mar 27, 2019
4626553
prefer string.includes over indexOf
jkwlui Mar 27, 2019
9152d5c
npm run fix
jkwlui Mar 27, 2019
680ea23
Merge branch 'master' into v4-signedurl
JustinBeckwith Mar 27, 2019
2b9f25f
Merge branch 'master' into v4-signedurl
jkwlui Mar 28, 2019
1a38919
docs: add a note on POST and X-Goog-Resumable
jkwlui Mar 28, 2019
7f0c1ff
SEVEN_DAYS = 604800
jkwlui Mar 28, 2019
8fe632c
emit warning when using default version
jkwlui Mar 29, 2019
2ff306d
emitWarning if using default version for signing
jkwlui Mar 29, 2019
b2d847e
restore stub
jkwlui Mar 29, 2019
024b2d3
add new line
jkwlui Mar 29, 2019
e9d74fb
test: v4 signed URL: conformance test (#638)
jkwlui Apr 1, 2019
e7ef608
Merge branch 'master' into v4-signedurl
jkwlui Apr 1, 2019
7af7110
remove default v2 warning
jkwlui Apr 3, 2019
88b4c3d
Merge branch 'master' into v4-signedurl
jkwlui Apr 3, 2019
fc54461
Merge branch 'master' into v4-signedurl
JustinBeckwith Apr 4, 2019
4146ba0
docs(samples): Samples for v4 Signed URL (#654)
jkwlui Apr 4, 2019
a57ea13
Merge branch 'master' into v4-signedurl
jkwlui Apr 4, 2019
4d079d3
remove timeout on conformance-test
jkwlui Apr 4, 2019
5e1b00d
npm run fix
jkwlui Apr 4, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
"async": "^2.0.1",
"compressible": "^2.0.12",
"concat-stream": "^2.0.0",
"dateformat": "^3.0.3",
"duplexify": "^3.5.0",
"extend": "^3.0.0",
"gcs-resumable-upload": "^1.0.0",
Expand All @@ -78,6 +79,7 @@
"@types/compressible": "^2.0.0",
"@types/concat-stream": "^1.6.0",
"@types/configstore": "^4.0.0",
"@types/dateformat": "^3.0.0",
"@types/extend": "^3.0.0",
"@types/mime": "^2.0.0",
"@types/mime-types": "^2.1.0",
Expand All @@ -88,6 +90,7 @@
"@types/proxyquire": "^1.3.28",
"@types/pumpify": "^1.4.1",
"@types/request": "^2.47.1",
"@types/sinon": "^7.0.10",
"@types/through2": "^2.0.33",
"@types/tmp": "0.0.34",
"@types/uuid": "^3.4.4",
Expand All @@ -101,6 +104,7 @@
"intelli-espower-loader": "^1.0.1",
"jsdoc": "^3.5.4",
"jsdoc-baseline": "git+https://github.com/hegemonic/jsdoc-baseline.git",
"linkinator": "^1.1.2",
"mocha": "^6.0.0",
"nock": "^10.0.1",
"node-fetch": "^2.2.0",
Expand All @@ -109,10 +113,10 @@
"power-assert": "^1.4.4",
"prettier": "^1.7.0",
"proxyquire": "^2.0.0",
"sinon": "^7.3.0",
"source-map-support": "^0.5.6",
"tmp": "^0.1.0",
"typescript": "~3.3.0",
"uuid": "^3.1.0",
"linkinator": "^1.1.2"
"uuid": "^3.1.0"
}
}
Loading