Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency gcs-resumable-upload to v1 #619

Merged
merged 1 commit into from
Mar 7, 2019

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 1, 2019

This PR contains the following updates:

Package Type Update Change References
gcs-resumable-upload dependencies major ^0.14.1 -> ^1.0.0 source

Release Notes

googleapis/gcs-resumable-upload

v1.0.0

Compare Source

02-28-2019 06:27 PST

This release has breaking changes. The underlying transport library was changed from request to gaxios. Any response objects returned via the API will now return a GaxiosResponse object.

Old Code
.on('response', function (resp, metadata) {
  console.log(resp.statusCode);
})
New Code
.on('response', function (resp) {
  console.log(resp.status);
});
Implementation Changes
  • fix: replace request with gaxios (#​174)
Documentation
  • docs: update links in contrib guide (#​184)
  • docs: add lint/fix example to contributing guide (#​177)
Internal / Testing Changes
  • chore(deps): update dependency mocha to v6 (#​185)
  • build: use linkinator for docs test (#​183)
  • build: create docs test npm scripts (#​182)
  • build: test using @​grpc/grpc-js in CI (#​181)
  • chore: move CONTRIBUTING.md to root (#​179)
  • chore(deps): update dependency typescript to ~3.3.0 (#​176)

Renovate configuration

📅 Schedule: "after 9am and before 3pm" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 1, 2019
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 1, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 1, 2019
@JustinBeckwith
Copy link
Contributor

@stephenplusplus can you figure out what we need to do to land this one?

@renovate renovate bot force-pushed the renovate/gcs-resumable-upload-1.x branch from 118371a to acfbab2 Compare March 1, 2019 17:12
@codecov
Copy link

codecov bot commented Mar 1, 2019

Codecov Report

Merging #619 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #619   +/-   ##
=======================================
  Coverage   97.94%   97.94%           
=======================================
  Files           9        9           
  Lines         874      874           
  Branches       99       99           
=======================================
  Hits          856      856           
  Misses          9        9           
  Partials        9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23a3cf0...38b1e8d. Read the comment docs.

@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 1, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 1, 2019
@stephenplusplus stephenplusplus self-assigned this Mar 1, 2019
@stephenplusplus stephenplusplus added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 5, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 5, 2019
@renovate renovate bot force-pushed the renovate/gcs-resumable-upload-1.x branch 2 times, most recently from 2c0db84 to f5aeec1 Compare March 5, 2019 18:09
@renovate renovate bot force-pushed the renovate/gcs-resumable-upload-1.x branch from f5aeec1 to 38b1e8d Compare March 7, 2019 00:19
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 7, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 7, 2019
@JustinBeckwith JustinBeckwith merged commit 58d4ea5 into master Mar 7, 2019
@renovate renovate bot deleted the renovate/gcs-resumable-upload-1.x branch March 7, 2019 01:35
@stephenplusplus
Copy link
Contributor

I was looking into this and it actually is broken on Node 8.

@JustinBeckwith
Copy link
Contributor

Oooooops. But it looked like the tests were all passing after the gaxios change?

@stephenplusplus
Copy link
Contributor

The gcs-resumable-upload tests pass, but something isn't working with these tests :\

Locally, too:

  1) storage
       write, read, and remove files
         stream write
           should resume an upload after an interruption:
     Uncaught Upload Client Broken Connection

@JustinBeckwith
Copy link
Contributor

I think I see what happened. We landed the PR to run system tests on node 10 yesterday. On re-run - all of the tests passed 🤦‍♂️

@stephenplusplus
Copy link
Contributor

Yeah :( I gave this issue a shout-out over here: googleapis/google-cloud-node#2905 in case we want to think about a way around this kinda thing bumping into us again in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants