-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update dependency gcs-resumable-upload to v1 #619
Conversation
@stephenplusplus can you figure out what we need to do to land this one? |
118371a
to
acfbab2
Compare
Codecov Report
@@ Coverage Diff @@
## master #619 +/- ##
=======================================
Coverage 97.94% 97.94%
=======================================
Files 9 9
Lines 874 874
Branches 99 99
=======================================
Hits 856 856
Misses 9 9
Partials 9 9 Continue to review full report at Codecov.
|
2c0db84
to
f5aeec1
Compare
f5aeec1
to
38b1e8d
Compare
I was looking into this and it actually is broken on Node 8. |
Oooooops. But it looked like the tests were all passing after the gaxios change? |
The gcs-resumable-upload tests pass, but something isn't working with these tests :\ Locally, too:
|
I think I see what happened. We landed the PR to run system tests on node 10 yesterday. On re-run - all of the tests passed 🤦♂️ |
Yeah :( I gave this issue a shout-out over here: googleapis/google-cloud-node#2905 in case we want to think about a way around this kinda thing bumping into us again in the future. |
This PR contains the following updates:
^0.14.1
->^1.0.0
Release Notes
googleapis/gcs-resumable-upload
v1.0.0
Compare Source
02-28-2019 06:27 PST
This release has breaking changes. The underlying transport library was changed from request to gaxios. Any
response
objects returned via the API will now return aGaxiosResponse
object.Old Code
New Code
Implementation Changes
Documentation
Internal / Testing Changes
Renovate configuration
📅 Schedule: "after 9am and before 3pm" (UTC).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻️ Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "
rebase!
".🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot. View repository job log here.