Bucket Policy Only Samples

[frankyn]

These are samples to support Bucket Policy Only Samples.

• Tests and linter pass
• Code coverage does not decrease (if any source code was changed)
• Appropriate docs were updated (if necessary)

I can't assign you @chestercun, PTAL. Thank you.

[JustinBeckwith]

LGTM once the tests (linter) all pass

[frankyn]

@JustinBeckwith silly question. This feature has a lockedTime in RFC 3339 format. I suspect the client should help developers convert this into a Date object. WDYT? I'm not a Node.js expert.

[jkwlui]

@frankyn looks like we've never return Date object for datetime strings in nodejs-storage.

@stephenplusplus have we ever discussed whether to convert datetime strings to Date object in handwritten libraries before?

[stephenplusplus]

Sorry I missed this question. I think our rule has been to simplify a handwritten response format as best we can, and leave the API's raw response format as it came.

Considering a made-up method:

file.getUsefulInfo((err, info, apiResponse) => {
  info.createdAt === Date('...')
  info.size === Number(8800)

  apiResponse.createdAt === 'long-string-of-numbers'
  apiResponse.size === '8800'
})

So, if a method exists and we can be more helpful by returning a handwritten response, we should be. For the apiResponse, I think we should leave it be, as opposed to iterating over it with best effort type conversion, as we might run into some unintentional side effects.

[frankyn]

Thanks @stephenplusplus and @kinwa91! Let's keep as-is. I'll resolve conflicts and merge after the workaround in this PR is no longer needed, e.g. Tomorrow EOD (Wednesday).

[frankyn]

@kinwa91 are you okay if I merge?