Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix samples test by adding approprate test variables #423

Merged
merged 3 commits into from
Oct 1, 2018

Conversation

jkwlui
Copy link
Member

@jkwlui jkwlui commented Oct 1, 2018

No description provided.

@ghost ghost assigned jkwlui Oct 1, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 1, 2018
Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take your word for it 🤷‍♂️

@jkwlui jkwlui merged commit 5b85129 into master Oct 1, 2018
@jkwlui jkwlui deleted the fix-samples-test branch October 1, 2018 20:55
frankyn pushed a commit that referenced this pull request Oct 3, 2018
* share environment variabes between system and samples test

* remove legacy kokoro build configs

* fix script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants