-
Notifications
You must be signed in to change notification settings - Fork 387
feat(listBuckets): Add support for returning partial success #2678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thiyaguk09
wants to merge
13
commits into
main
Choose a base branch
from
feat/list-buckets-partial-success
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+188
−1
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
1739bb7
feat(listBuckets): Add support for returning partial success
thiyaguk09 8f44d3f
docs(samples): Add listBucketsPartialSuccess sample
thiyaguk09 7fab754
code refactor
thiyaguk09 b03ac55
minor fix
thiyaguk09 26c8780
Ensure positional consistency for optional callback results
thiyaguk09 d13ce55
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] c894d82
Enable partial success via placeholder objects
thiyaguk09 91c6d04
bug fix
thiyaguk09 934af50
addressing commends
thiyaguk09 4d22b2a
refactor: Simplify partial success placeholder logic
thiyaguk09 10a7e87
addressing comments
thiyaguk09 3242ff6
Revert "addressing comments"
thiyaguk09 ad88857
addressing comments
thiyaguk09 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| /** | ||
| * Copyright 2025 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| function main() { | ||
| // [START storage_list_buckets_partial_success] | ||
| // Imports the Google Cloud client library | ||
| const {Storage} = require('@google-cloud/storage'); | ||
|
|
||
| // Creates a client | ||
| const storage = new Storage(); | ||
|
|
||
| async function listBucketsPartialSuccess() { | ||
| const option = { | ||
| returnPartialSuccess: true, | ||
| maxResults: 5, | ||
| }; | ||
| const [buckets, nextQuery, apiResponse] = await storage.getBuckets(option); | ||
|
|
||
| if (nextQuery && nextQuery.pageToken) { | ||
| console.log(`Next Page Token: ${nextQuery.pageToken}`); | ||
| } | ||
|
|
||
| console.log('\nBuckets:'); | ||
| buckets.forEach(bucket => { | ||
| if (bucket.unreachable) { | ||
| console.log(`${bucket.name} (unreachable: ${bucket.unreachable})`); | ||
| } else { | ||
| console.log(`${bucket.name}`); | ||
| } | ||
| }); | ||
|
|
||
| if (apiResponse.unreachable && apiResponse.unreachable.length > 0) { | ||
| console.log('\nUnreachable Buckets:'); | ||
| apiResponse.unreachable.forEach(item => { | ||
| console.log(item); | ||
| }); | ||
| } | ||
| } | ||
|
|
||
| listBucketsPartialSuccess().catch(console.error); | ||
| // [END storage_list_buckets_partial_success] | ||
| } | ||
|
|
||
| main(...process.argv.slice(2)); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -189,6 +189,7 @@ export interface GetBucketsRequest { | |||||||||||||||||
| userProject?: string; | ||||||||||||||||||
| softDeleted?: boolean; | ||||||||||||||||||
| generation?: number; | ||||||||||||||||||
| returnPartialSuccess?: boolean; | ||||||||||||||||||
| } | ||||||||||||||||||
|
|
||||||||||||||||||
| export interface HmacKeyResourceResponse { | ||||||||||||||||||
|
|
@@ -1338,17 +1339,38 @@ export class Storage extends Service { | |||||||||||||||||
| } | ||||||||||||||||||
|
|
||||||||||||||||||
| const itemsArray = resp.items ? resp.items : []; | ||||||||||||||||||
| const unreachableArray = resp.unreachable ? resp.unreachable : []; | ||||||||||||||||||
|
|
||||||||||||||||||
| const buckets = itemsArray.map((bucket: BucketMetadata) => { | ||||||||||||||||||
| const bucketInstance = this.bucket(bucket.id!); | ||||||||||||||||||
| bucketInstance.metadata = bucket; | ||||||||||||||||||
|
|
||||||||||||||||||
| return bucketInstance; | ||||||||||||||||||
| }); | ||||||||||||||||||
|
|
||||||||||||||||||
| let results: Bucket[] = buckets; | ||||||||||||||||||
| if (unreachableArray.length > 0) { | ||||||||||||||||||
| results = unreachableArray.reduce( | ||||||||||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oversight on my suggestion.
Suggested change
|
||||||||||||||||||
| (acc: Bucket[], fullPath: string) => { | ||||||||||||||||||
| const name = fullPath.split('/').pop(); | ||||||||||||||||||
| if (name) { | ||||||||||||||||||
| const placeholder = this.bucket(name); | ||||||||||||||||||
| placeholder.unreachable = true; | ||||||||||||||||||
| placeholder.metadata = {}; | ||||||||||||||||||
| acc.push(placeholder); | ||||||||||||||||||
| } | ||||||||||||||||||
|
|
||||||||||||||||||
| return acc; | ||||||||||||||||||
| }, | ||||||||||||||||||
| buckets | ||||||||||||||||||
| ); | ||||||||||||||||||
| } | ||||||||||||||||||
|
|
||||||||||||||||||
| const nextQuery = resp.nextPageToken | ||||||||||||||||||
| ? Object.assign({}, options, {pageToken: resp.nextPageToken}) | ||||||||||||||||||
| : null; | ||||||||||||||||||
|
|
||||||||||||||||||
| callback(null, buckets, nextQuery, resp); | ||||||||||||||||||
| callback(null, results, nextQuery, resp); | ||||||||||||||||||
| } | ||||||||||||||||||
| ); | ||||||||||||||||||
| } | ||||||||||||||||||
|
|
||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.